Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1052)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart

Issue 2751083002: Revert "[kernel] offsets on direct property get/set" (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart ('k') | pkg/kernel/binary.md » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart b/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart
index 19015a14a1646e46b5574e2536104ece07a53d8e..eea4554c4d0cf15d1c9673cd12ac9ba669764a58 100644
--- a/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart
@@ -222,25 +222,23 @@ class NullAwarePropertyAccessor extends Accessor {
class SuperPropertyAccessor extends Accessor {
Name name;
Member getter, setter;
- final int charOffset;
- SuperPropertyAccessor(this.name, this.getter, this.setter, this.charOffset);
+ SuperPropertyAccessor(this.name, this.getter, this.setter);
_makeRead() {
if (getter == null) return makeInvalidRead();
// TODO(ahe): Use [DirectPropertyGet] when possible.
- Expression result = new DirectPropertyGet(new ThisExpression(), getter)
- ..fileOffset = charOffset;
- result = new SuperPropertyGet(name, getter)..fileOffset = charOffset;
+ Expression result = new DirectPropertyGet(new ThisExpression(), getter);
+ result = new SuperPropertyGet(name, getter);
return result;
}
_makeWrite(Expression value, bool voidContext) {
if (setter == null) return makeInvalidWrite(value);
// TODO(ahe): Use [DirectPropertySet] when possible.
- Expression result = new DirectPropertySet(
- new ThisExpression(), setter, value)..fileOffset = charOffset;
- result = new SuperPropertySet(name, value, setter)..fileOffset = charOffset;
+ Expression result =
+ new DirectPropertySet(new ThisExpression(), setter, value);
+ result = new SuperPropertySet(name, value, setter);
return result;
}
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart ('k') | pkg/kernel/binary.md » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698