Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(368)

Side by Side Diff: pkg/kernel/lib/binary/ast_to_binary.dart

Issue 2751083002: Revert "[kernel] offsets on direct property get/set" (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 library kernel.ast_to_binary; 4 library kernel.ast_to_binary;
5 5
6 import '../ast.dart'; 6 import '../ast.dart';
7 import '../import_table.dart'; 7 import '../import_table.dart';
8 import 'tag.dart'; 8 import 'tag.dart';
9 import 'dart:convert'; 9 import 'dart:convert';
10 import 'dart:typed_data'; 10 import 'dart:typed_data';
(...skipping 483 matching lines...) Expand 10 before | Expand all | Expand 10 after
494 494
495 visitSuperPropertySet(SuperPropertySet node) { 495 visitSuperPropertySet(SuperPropertySet node) {
496 writeByte(Tag.SuperPropertySet); 496 writeByte(Tag.SuperPropertySet);
497 writeName(node.name); 497 writeName(node.name);
498 writeNode(node.value); 498 writeNode(node.value);
499 writeReference(node.interfaceTargetReference); 499 writeReference(node.interfaceTargetReference);
500 } 500 }
501 501
502 visitDirectPropertyGet(DirectPropertyGet node) { 502 visitDirectPropertyGet(DirectPropertyGet node) {
503 writeByte(Tag.DirectPropertyGet); 503 writeByte(Tag.DirectPropertyGet);
504 writeOffset(node, node.fileOffset);
505 writeNode(node.receiver); 504 writeNode(node.receiver);
506 writeReference(node.targetReference); 505 writeReference(node.targetReference);
507 } 506 }
508 507
509 visitDirectPropertySet(DirectPropertySet node) { 508 visitDirectPropertySet(DirectPropertySet node) {
510 writeByte(Tag.DirectPropertySet); 509 writeByte(Tag.DirectPropertySet);
511 writeOffset(node, node.fileOffset);
512 writeNode(node.receiver); 510 writeNode(node.receiver);
513 writeReference(node.targetReference); 511 writeReference(node.targetReference);
514 writeNode(node.value); 512 writeNode(node.value);
515 } 513 }
516 514
517 visitStaticGet(StaticGet node) { 515 visitStaticGet(StaticGet node) {
518 writeByte(Tag.StaticGet); 516 writeByte(Tag.StaticGet);
519 writeOffset(node, node.fileOffset); 517 writeOffset(node, node.fileOffset);
520 writeReference(node.targetReference); 518 writeReference(node.targetReference);
521 } 519 }
(...skipping 761 matching lines...) Expand 10 before | Expand all | Expand 10 after
1283 void flush() { 1281 void flush() {
1284 _sink.add(_buffer.sublist(0, length)); 1282 _sink.add(_buffer.sublist(0, length));
1285 _buffer = new Uint8List(SIZE); 1283 _buffer = new Uint8List(SIZE);
1286 length = 0; 1284 length = 0;
1287 } 1285 }
1288 1286
1289 void flushAndDestroy() { 1287 void flushAndDestroy() {
1290 _sink.add(_buffer.sublist(0, length)); 1288 _sink.add(_buffer.sublist(0, length));
1291 } 1289 }
1292 } 1290 }
OLDNEW
« no previous file with comments | « pkg/kernel/lib/binary/ast_from_binary.dart ('k') | pkg/kernel/lib/transformations/mixin_full_resolution.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698