Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1027)

Unified Diff: pkg/kernel/lib/transformations/mixin_full_resolution.dart

Issue 2751083002: Revert "[kernel] offsets on direct property get/set" (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/kernel/lib/transformations/mixin_full_resolution.dart
diff --git a/pkg/kernel/lib/transformations/mixin_full_resolution.dart b/pkg/kernel/lib/transformations/mixin_full_resolution.dart
index 8d8b345213b1aeef1a8c5599c91fb4ed7f364ce0..7f92ce9cf296fada7085e3013f95df9ab1ba3ec0 100644
--- a/pkg/kernel/lib/transformations/mixin_full_resolution.dart
+++ b/pkg/kernel/lib/transformations/mixin_full_resolution.dart
@@ -187,8 +187,7 @@ class SuperCallResolutionTransformer extends Transformer {
visitSuperPropertyGet(SuperPropertyGet node) {
Member target = hierarchy.getDispatchTarget(lookupClass, node.name);
if (target != null) {
- return new DirectPropertyGet(new ThisExpression(), target)
- ..fileOffset = node.fileOffset;
+ return new DirectPropertyGet(new ThisExpression(), target);
} else {
return _callNoSuchMethod(node.name.name, new Arguments.empty(), node,
isGetter: true, isSuper: true);
@@ -200,8 +199,7 @@ class SuperCallResolutionTransformer extends Transformer {
hierarchy.getDispatchTarget(lookupClass, node.name, setter: true);
if (target != null) {
return new DirectPropertySet(
- new ThisExpression(), target, visit(node.value))
- ..fileOffset = node.fileOffset;
+ new ThisExpression(), target, visit(node.value));
} else {
// Call has to return right-hand-side.
VariableDeclaration rightHandSide =
« no previous file with comments | « pkg/kernel/lib/binary/ast_to_binary.dart ('k') | runtime/observatory/tests/service/step_through_property_get_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698