Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(241)

Side by Side Diff: pkg/kernel/binary.md

Issue 2751083002: Revert "[kernel] offsets on direct property get/set" (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 This file describes the binary format of Dart Kernel. 1 This file describes the binary format of Dart Kernel.
2 2
3 Notation 3 Notation
4 -------- 4 --------
5 Bitmasks are described with the syntax: 5 Bitmasks are described with the syntax:
6 ```scala 6 ```scala
7 Byte flags (flag1, flag2, ..., flagN) 7 Byte flags (flag1, flag2, ..., flagN)
8 ``` 8 ```
9 where 'flag<N>' is the N-th least significant bit, 9 where 'flag<N>' is the N-th least significant bit,
10 (so flag1 is the least significant bit). 10 (so flag1 is the least significant bit).
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
388 388
389 type SuperPropertySet extends Expression { 389 type SuperPropertySet extends Expression {
390 Byte tag = 25; 390 Byte tag = 25;
391 Name name; 391 Name name;
392 Expression value; 392 Expression value;
393 MemberReference interfaceTarget; // May be NullReference. 393 MemberReference interfaceTarget; // May be NullReference.
394 } 394 }
395 395
396 type DirectPropertyGet extends Expression { 396 type DirectPropertyGet extends Expression {
397 Byte tag = 15; // Note: tag is out of order 397 Byte tag = 15; // Note: tag is out of order
398 FileOffset fileOffset;
399 Expression receiver; 398 Expression receiver;
400 MemberReference target; 399 MemberReference target;
401 } 400 }
402 401
403 type DirectPropertySet extends Expression { 402 type DirectPropertySet extends Expression {
404 Byte tag = 16; // Note: tag is out of order 403 Byte tag = 16; // Note: tag is out of order
405 FileOffset fileOffset;
406 Expression receiver; 404 Expression receiver;
407 MemberReference target; 405 MemberReference target;
408 Expression value; 406 Expression value;
409 } 407 }
410 408
411 type StaticGet extends Expression { 409 type StaticGet extends Expression {
412 Byte tag = 26; 410 Byte tag = 26;
413 FileOffset fileOffset; 411 FileOffset fileOffset;
414 MemberReference target; 412 MemberReference target;
415 } 413 }
(...skipping 507 matching lines...) Expand 10 before | Expand all | Expand 10 after
923 921
924 /* enum BaseClassKind { None, Exact, Subclass, Subtype, } */ 922 /* enum BaseClassKind { None, Exact, Subclass, Subtype, } */
925 923
926 type InferredValue { 924 type InferredValue {
927 ClassReference baseClass; // May be NullReference if kind = None. 925 ClassReference baseClass; // May be NullReference if kind = None.
928 Byte kind; // Index into BaseClassKind. 926 Byte kind; // Index into BaseClassKind.
929 Byte valueBits; // See lib/type_propagation/type_propagation.dart 927 Byte valueBits; // See lib/type_propagation/type_propagation.dart
930 } 928 }
931 929
932 ``` 930 ```
OLDNEW
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart ('k') | pkg/kernel/lib/binary/ast_from_binary.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698