Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Issue 2750533003: Temporarily CHECK use after free in Value (Closed)

Created:
3 years, 9 months ago by vabr (Chromium)
Modified:
3 years, 9 months ago
Reviewers:
CC:
chromium-reviews, qsr+mojo_chromium.org, vmpstr+watch_chromium.org, wfh+watch_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, tracing+reviews_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Temporarily CHECK use after free in Value COMMIT=false This CL was abandoned in favour of https://codereview.chromium.org/2743363004, because the minor change would spread into too many depending switch-case statements. One of the hypotheses for https://crbug.com/697817 is that a Value is used after free (see #5 there). To verify/refute that hypothesis, this CL temporarily adds CHECKS and a new Value::Type (DELETED). This change will be reverted after a couple of days in Canary, and only serves investigation purposes. BUG=697817

Patch Set 1 #

Patch Set 2 : Android #

Patch Set 3 : Fix more #

Patch Set 4 : Windows #

Patch Set 5 : Mac #

Patch Set 6 : Fix more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+83 lines, -1 line) Patch
M base/json/json_writer.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M base/trace_event/trace_event_argument.cc View 2 chunks +10 lines, -0 lines 0 comments Download
M base/values.h View 1 chunk +2 lines, -1 line 0 comments Download
M base/values.cc View 8 chunks +29 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/applescript/apple_event_util.mm View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M components/policy/core/browser/android/policy_converter.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M components/policy/core/common/policy_test_utils.cc View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M components/policy/core/common/registry_dict.cc View 1 2 3 4 5 1 chunk +5 lines, -0 lines 0 comments Download
M content/browser/android/java/gin_java_script_to_java_types_coercion.cc View 1 2 3 4 5 1 chunk +4 lines, -0 lines 0 comments Download
M ipc/ipc_message_utils.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/common/values_struct_traits.h View 1 chunk +4 lines, -0 lines 0 comments Download
M ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 23 (22 generated)
vabr (Chromium)
3 years, 9 months ago (2017-03-14 14:44:23 UTC) #23
Message was sent while issue was closed.
This was closed in favour of https://codereview.chromium.org/2743363004

Powered by Google App Engine
This is Rietveld 408576698