ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc - Issue 2750533003: Temporarily CHECK use after free in Value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc

Issue 2750533003: Temporarily CHECK use after free in Value (Closed)

Patch Set: Fix more Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc

diff --git a/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc b/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc

index e69aecc3444a7860fe0b5b379a9ed7a957ae5337..7eaa61c1c4112536092c04ad5fa70597cf7992ab 100644

--- a/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc

+++ b/ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc

@@ -75,6 +75,10 @@ PP_Var PPB_X509Certificate_Fields::GetFieldAsPPVar(

case base::Value::Type::LIST:

// Not handled.

break;

+ case base::Value::Type::DELETED:

+ // TODO(crbug.com/697817): This means |value| is used after free.

+ CHECK(false);

+ break;

}

// Should not reach here.

« no previous file with comments | « mojo/common/values_struct_traits.h ('k') | no next file » | no next file with comments »