Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: ipc/ipc_message_utils.cc

Issue 2750533003: Temporarily CHECK use after free in Value (Closed)
Patch Set: Fix more Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ipc/ipc_message_utils.cc
diff --git a/ipc/ipc_message_utils.cc b/ipc/ipc_message_utils.cc
index bf8daa5d9741189df50bdac48f7b39cf5744e5a2..df5e2965a856c4eb0712ecd765e5b5937ad88b9a 100644
--- a/ipc/ipc_message_utils.cc
+++ b/ipc/ipc_message_utils.cc
@@ -202,6 +202,11 @@ void WriteValue(base::Pickle* m, const base::Value* value, int recursion) {
}
break;
}
+ case base::Value::Type::DELETED: {
+ // TODO(crbug.com/697817): This means a use-after-free.
+ CHECK(false);
+ return;
+ }
}
}
« no previous file with comments | « content/browser/android/java/gin_java_script_to_java_types_coercion.cc ('k') | mojo/common/values_struct_traits.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698