ipc/ipc_message_utils.cc - Issue 2750533003: Temporarily CHECK use after free in Value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ipc/ipc_message_utils.cc

Issue 2750533003: Temporarily CHECK use after free in Value (Closed)

Patch Set: Fix more Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ipc/ipc_message_utils.cc

diff --git a/ipc/ipc_message_utils.cc b/ipc/ipc_message_utils.cc

index bf8daa5d9741189df50bdac48f7b39cf5744e5a2..df5e2965a856c4eb0712ecd765e5b5937ad88b9a 100644

--- a/ipc/ipc_message_utils.cc

+++ b/ipc/ipc_message_utils.cc

@@ -202,6 +202,11 @@ void WriteValue(base::Pickle* m, const base::Value* value, int recursion) {

}

break;

}

+ case base::Value::Type::DELETED: {

+ // TODO(crbug.com/697817): This means a use-after-free.

+ CHECK(false);

+ return;

+ }

}