Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1854)

Unified Diff: mojo/common/values_struct_traits.h

Issue 2750533003: Temporarily CHECK use after free in Value (Closed)
Patch Set: Fix more Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ipc/ipc_message_utils.cc ('k') | ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/common/values_struct_traits.h
diff --git a/mojo/common/values_struct_traits.h b/mojo/common/values_struct_traits.h
index befcf3a6ea2816dd56e56f0a50933d9cec3548e0..766b90b49ec7194ac816d7a81041d40c632b2770 100644
--- a/mojo/common/values_struct_traits.h
+++ b/mojo/common/values_struct_traits.h
@@ -135,6 +135,10 @@ struct UnionTraits<common::mojom::ValueDataView, base::Value> {
return common::mojom::ValueDataView::Tag::DICTIONARY_VALUE;
case base::Value::Type::LIST:
return common::mojom::ValueDataView::Tag::LIST_VALUE;
+ case base::Value::Type::DELETED:
+ // TODO(crbug.com/697817): This means a use-after-free.
+ CHECK(false);
+ return common::mojom::ValueDataView::Tag::NULL_VALUE;
}
NOTREACHED();
return common::mojom::ValueDataView::Tag::NULL_VALUE;
« no previous file with comments | « ipc/ipc_message_utils.cc ('k') | ppapi/shared_impl/private/ppb_x509_certificate_private_shared.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698