Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(797)

Unified Diff: base/trace_event/trace_event_argument.cc

Issue 2750533003: Temporarily CHECK use after free in Value (Closed)
Patch Set: Fix more Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/json/json_writer.cc ('k') | base/values.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/trace_event/trace_event_argument.cc
diff --git a/base/trace_event/trace_event_argument.cc b/base/trace_event/trace_event_argument.cc
index db702b6231e5249c9526d27ac439450c732e39a6..f6cb8c8e65cfe6ffb2ca150032e941996d6eeefe 100644
--- a/base/trace_event/trace_event_argument.cc
+++ b/base/trace_event/trace_event_argument.cc
@@ -292,6 +292,11 @@ void TracedValue::SetBaseValueWithCopiedName(base::StringPiece name,
AppendBaseValue(*base_value);
EndArray();
} break;
+
+ case base::Value::Type::DELETED:
+ // TODO(crbug.com/697817): This means |value| is used after free.
+ CHECK(false);
+ return;
}
}
@@ -346,6 +351,11 @@ void TracedValue::AppendBaseValue(const base::Value& value) {
AppendBaseValue(*base_value);
EndArray();
} break;
+
+ case base::Value::Type::DELETED:
+ // TODO(crbug.com/697817): This means |value| is used after free.
+ CHECK(false);
+ return;
}
}
« no previous file with comments | « base/json/json_writer.cc ('k') | base/values.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698