Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(512)

Unified Diff: components/policy/core/common/registry_dict.cc

Issue 2750533003: Temporarily CHECK use after free in Value (Closed)
Patch Set: Fix more Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/policy/core/common/registry_dict.cc
diff --git a/components/policy/core/common/registry_dict.cc b/components/policy/core/common/registry_dict.cc
index 29c9df73133d7ec59a75f9a95b936961b18a4f2e..bd274a3b8e4757f641aaa6fa4d34f6e1181320ce 100644
--- a/components/policy/core/common/registry_dict.cc
+++ b/components/policy/core/common/registry_dict.cc
@@ -138,6 +138,11 @@ std::unique_ptr<base::Value> ConvertValue(const base::Value& value,
case base::Value::Type::BINARY:
// No conversion possible.
break;
+
+ case base::Value::Type::DELETED:
+ // TODO(crbug.com/697817): This means a use-after-free.
+ CHECK(false);
+ break;
}
LOG(WARNING) << "Failed to convert " << value.GetType()

Powered by Google App Engine
This is Rietveld 408576698