Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(419)

Issue 2749753002: Migrate WTF::Deque::removeFirst() to ::pop_front() (Closed)

Created:
3 years, 9 months ago by pilgrim_google
Modified:
3 years, 9 months ago
CC:
ajuma+watch_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-html_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-wtf_chromium.org, Rik, caseq+blink_chromium.org, chromium-reviews, danakj+watch_chromium.org, devtools-reviews_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, fmalita+watch_chromium.org, jbroman, Justin Novosad, kinuko+watch, kozyatinskiy+blink_chromium.org, loading-reviews+parser_chromium.org, lushnikov+blink_chromium.org, Mikhail, pdr+graphicswatchlist_chromium.org, pfeldman+blink_chromium.org, piman+watch_chromium.org, rwlbuis, Stephen Chennney, tyoshino+watch_chromium.org, yhirano+watch_chromium.org, jsbell
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Migrate WTF::Deque::removeFirst() to ::pop_front() As discussed on platform-architecture-dev [0], there is interest in normalizing the methods of WTF classes to better align with std classes. There are no functional changes. [0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion BUG=662431 Review-Url: https://codereview.chromium.org/2749753002 Cr-Commit-Position: refs/heads/master@{#456623} Committed: https://chromium.googlesource.com/chromium/src/+/5c048822625c48c44e4e4336abc50c033ad8a251

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -32 lines) Patch
M third_party/WebKit/Source/core/css/CSSFontFace.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/editing/commands/UndoStack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/inspector/ConsoleMessageStorage.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BytesConsumer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/fetch/BytesConsumerTestUtil.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/fetch/DataConsumerHandleTestUtil.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechSynthesis.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/SQLTransactionCoordinator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DocumentWebSocketChannel.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/ScriptRunIterator.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/gpu/SharedContextRateLimiter.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/wtf/Deque.h View 4 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/wtf/DequeTest.cpp View 4 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
pilgrim_google
3 years, 9 months ago (2017-03-14 02:01:33 UTC) #3
haraken
LGTM
3 years, 9 months ago (2017-03-14 02:38:33 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2749753002/1
3 years, 9 months ago (2017-03-14 02:44:00 UTC) #8
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 04:43:58 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5c048822625c48c44e4e4336abc5...

Powered by Google App Engine
This is Rietveld 408576698