Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(855)

Unified Diff: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp

Issue 2749753002: Migrate WTF::Deque::removeFirst() to ::pop_front() (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
diff --git a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
index d06f09efdab60a23a2698f06680195b1b508655f..6e269aec72fc7529e455e6b1f7483f80e9a9f8be 100644
--- a/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
+++ b/third_party/WebKit/Source/modules/presentation/PresentationConnection.cpp
@@ -319,14 +319,14 @@ void PresentationConnection::handleMessageQueue() {
switch (message->type) {
case MessageTypeText:
client->sendString(m_url, m_id, message->text, m_proxy.get());
- m_messages.removeFirst();
+ m_messages.pop_front();
break;
case MessageTypeArrayBuffer:
client->sendArrayBuffer(
m_url, m_id,
static_cast<const uint8_t*>(message->arrayBuffer->data()),
message->arrayBuffer->byteLength(), m_proxy.get());
- m_messages.removeFirst();
+ m_messages.pop_front();
break;
case MessageTypeBlob:
ASSERT(!m_blobLoader);
@@ -483,7 +483,7 @@ void PresentationConnection::didFinishLoadingBlob(DOMArrayBuffer* buffer) {
buffer->byteLength(), m_proxy.get());
}
- m_messages.removeFirst();
+ m_messages.pop_front();
m_blobLoader.clear();
handleMessageQueue();
}
@@ -493,7 +493,7 @@ void PresentationConnection::didFailLoadingBlob(
ASSERT(!m_messages.isEmpty() && m_messages.first()->type == MessageTypeBlob);
// FIXME: generate error message?
// Ignore the current failed blob item and continue with next items.
- m_messages.removeFirst();
+ m_messages.pop_front();
m_blobLoader.clear();
handleMessageQueue();
}

Powered by Google App Engine
This is Rietveld 408576698