third_party/WebKit/Source/core/editing/commands/UndoStack.cpp - Issue 2749753002: Migrate WTF::Deque::removeFirst() to ::pop_front()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/UndoStack.cpp

Issue 2749753002: Migrate WTF::Deque::removeFirst() to ::pop_front() (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/commands/UndoStack.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/UndoStack.cpp b/third_party/WebKit/Source/core/editing/commands/UndoStack.cpp

index 51de7da95da2d8c65569c7103e14d2349ca876ff..10db110a7531ab2cf3ef12d567c773761036f94a 100644

--- a/third_party/WebKit/Source/core/editing/commands/UndoStack.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/UndoStack.cpp

@@ -48,7 +48,7 @@ void UndoStack::registerUndoStep(UndoStep* step) {

if (m_undoStack.size())

DCHECK_GE(step->sequenceNumber(), m_undoStack.back()->sequenceNumber());

if (m_undoStack.size() == maximumUndoStackDepth)

- m_undoStack.removeFirst(); // drop oldest item off the far end

+ m_undoStack.pop_front(); // drop oldest item off the far end

if (!m_inRedo)

m_redoStack.clear();

m_undoStack.push_back(step);