Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(903)

Unified Diff: third_party/WebKit/Source/wtf/DequeTest.cpp

Issue 2749753002: Migrate WTF::Deque::removeFirst() to ::pop_front() (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/wtf/Deque.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/wtf/DequeTest.cpp
diff --git a/third_party/WebKit/Source/wtf/DequeTest.cpp b/third_party/WebKit/Source/wtf/DequeTest.cpp
index ef0da37ea2b0808158120ac45d56db13234d24c9..f3a8873e84e4f157a04ca64db1c5b946c72a6d18 100644
--- a/third_party/WebKit/Source/wtf/DequeTest.cpp
+++ b/third_party/WebKit/Source/wtf/DequeTest.cpp
@@ -204,13 +204,13 @@ void ownPtrTest() {
EXPECT_EQ(0, destructNumber);
EXPECT_EQ(0, deque.first()->get());
- deque.removeFirst();
+ deque.pop_front();
EXPECT_EQ(1, deque.first()->get());
EXPECT_EQ(1u, deque.size());
EXPECT_EQ(1, destructNumber);
std::unique_ptr<DestructCounter> ownCounter1 = std::move(deque.first());
- deque.removeFirst();
+ deque.pop_front();
EXPECT_EQ(counter1, ownCounter1->get());
EXPECT_EQ(0u, deque.size());
EXPECT_EQ(1, destructNumber);
@@ -411,7 +411,7 @@ void testDestructorAndConstructorCallsWhenSwappingWithInlineCapacity() {
EXPECT_EQ(j, LivenessCounter::s_live);
EXPECT_EQ(j, deque.size());
for (unsigned k = 0; k < i; k++)
- deque.removeFirst();
+ deque.pop_front();
EXPECT_EQ(j - i, LivenessCounter::s_live);
EXPECT_EQ(j - i, deque.size());
@@ -439,7 +439,7 @@ void testDestructorAndConstructorCallsWhenSwappingWithInlineCapacity() {
EXPECT_EQ(j - i, deque.size());
EXPECT_EQ(3u, deque2.size());
- deque2.removeFirst();
+ deque2.pop_front();
deque2.push_back(&counter);
}
}
@@ -526,7 +526,7 @@ TEST(DequeTest, UniquePtr) {
EXPECT_EQ(2, *last);
EXPECT_EQ(2u, deque.size());
- deque.removeFirst();
+ deque.pop_front();
deque.pop_back();
EXPECT_EQ(0u, deque.size());
« no previous file with comments | « third_party/WebKit/Source/wtf/Deque.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698