Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Side by Side Diff: third_party/WebKit/Source/core/html/parser/HTMLParserScriptRunner.cpp

Issue 2749753002: Migrate WTF::Deque::removeFirst() to ::pop_front() (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2010 Google, Inc. All Rights Reserved. 2 * Copyright (C) 2010 Google, Inc. All Rights Reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 356 matching lines...) Expand 10 before | Expand all | Expand 10 after
367 if (pendingScript == parserBlockingScript()) { 367 if (pendingScript == parserBlockingScript()) {
368 m_parserBlockingScript = nullptr; 368 m_parserBlockingScript = nullptr;
369 } else { 369 } else {
370 CHECK_EQ(pendingScript, m_scriptsToExecuteAfterParsing.first()); 370 CHECK_EQ(pendingScript, m_scriptsToExecuteAfterParsing.first());
371 371
372 // TODO(hiroshige): Remove this CHECK() before going to beta. 372 // TODO(hiroshige): Remove this CHECK() before going to beta.
373 // This is only to make clusterfuzz to find a test case that executes 373 // This is only to make clusterfuzz to find a test case that executes
374 // this code path. 374 // this code path.
375 CHECK(false); 375 CHECK(false);
376 376
377 m_scriptsToExecuteAfterParsing.removeFirst(); 377 m_scriptsToExecuteAfterParsing.pop_front();
378 // TODO(hiroshige): executeScriptsWaitingForParsing() should be 378 // TODO(hiroshige): executeScriptsWaitingForParsing() should be
379 // called later at the appropriate time. https://crbug.com/696775 379 // called later at the appropriate time. https://crbug.com/696775
380 } 380 }
381 381
382 return; 382 return;
383 } 383 }
384 384
385 // If the script was blocked as part of document.write intervention, 385 // If the script was blocked as part of document.write intervention,
386 // then send an asynchronous GET request with an interventions header. 386 // then send an asynchronous GET request with an interventions header.
387 possiblyFetchBlockedDocWriteScript(pendingScript); 387 possiblyFetchBlockedDocWriteScript(pendingScript);
(...skipping 304 matching lines...) Expand 10 before | Expand all | Expand 10 after
692 692
693 DEFINE_TRACE(HTMLParserScriptRunner) { 693 DEFINE_TRACE(HTMLParserScriptRunner) {
694 visitor->trace(m_document); 694 visitor->trace(m_document);
695 visitor->trace(m_host); 695 visitor->trace(m_host);
696 visitor->trace(m_parserBlockingScript); 696 visitor->trace(m_parserBlockingScript);
697 visitor->trace(m_scriptsToExecuteAfterParsing); 697 visitor->trace(m_scriptsToExecuteAfterParsing);
698 PendingScriptClient::trace(visitor); 698 PendingScriptClient::trace(visitor);
699 } 699 }
700 700
701 } // namespace blink 701 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698