Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2746823002: Correct elementMatches filter for datalist.options (Closed)

Created:
3 years, 9 months ago by MartinRogalla
Modified:
3 years, 9 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-html_chromium.org, blink-reviews-w3ctests_chromium.org, chromium-reviews, dglazkov+blink
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Correct elementMatches filter for datalist.options The filter should match all option elements [1], even if they are empty or disabled. This patch fixes the filter and ensures that the tests in [2] pass. All callers have been updated to filter on empty and disabled values, except for the call from V8HTMLDataListElement. The `fast/forms/datalist/datalist.html` test was removed as the correct behavior is checked by `wpt/html/semantics/forms/the-datalist-element/datalistoptions.html`. [1] - https://html.spec.whatwg.org/multipage/forms.html#dom-datalist-options [2] - http://w3c-test.org/html/semantics/forms/the-datalist-element/datalistoptions.html BUG=687073 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2746823002 Cr-Commit-Position: refs/heads/master@{#456586} Committed: https://chromium.googlesource.com/chromium/src/+/d08576a42a3c298ce3b8a39f92f58440446e303d

Patch Set 1 #

Patch Set 2 : Remove superfluous test, added filter to callees. #

Messages

Total messages: 16 (10 generated)
MartinRogalla
3 years, 9 months ago (2017-03-13 18:38:11 UTC) #3
MartinRogalla
3 years, 9 months ago (2017-03-13 19:08:23 UTC) #5
MartinRogalla
On 2017/03/13 19:08:23, MartinRogalla wrote: The failure is not due to the patch, correct?
3 years, 9 months ago (2017-03-13 22:35:33 UTC) #10
tkent
lgtm
3 years, 9 months ago (2017-03-13 23:49:15 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2746823002/20001
3 years, 9 months ago (2017-03-13 23:49:42 UTC) #13
commit-bot: I haz the power
3 years, 9 months ago (2017-03-14 02:36:41 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d08576a42a3c298ce3b8a39f92f5...

Powered by Google App Engine
This is Rietveld 408576698