third_party/WebKit/Source/core/html/HTMLDataListOptionsCollection.h - Issue 2746823002: Correct elementMatches filter for datalist.options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLDataListOptionsCollection.h

Issue 2746823002: Correct elementMatches filter for datalist.options (Closed)

Patch Set: Remove superfluous test, added filter to callees. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/forms/datalist/datalist-expected.txt ('k') | third_party/WebKit/Source/core/html/HTMLInputElement.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/HTMLDataListOptionsCollection.h

diff --git a/third_party/WebKit/Source/core/html/HTMLDataListOptionsCollection.h b/third_party/WebKit/Source/core/html/HTMLDataListOptionsCollection.h

index 64fcd6b233c0891b5a1fb795bbd8b84abd641015..4b15533033c05eae5e06760259e735cd9e7f013a 100644

--- a/third_party/WebKit/Source/core/html/HTMLDataListOptionsCollection.h

+++ b/third_party/WebKit/Source/core/html/HTMLDataListOptionsCollection.h

@@ -37,12 +37,7 @@ DEFINE_TYPE_CASTS(HTMLDataListOptionsCollection,

inline bool HTMLDataListOptionsCollection::elementMatches(

const HTMLElement& element) const {

- if (isHTMLOptionElement(element)) {

- const HTMLOptionElement& option = toHTMLOptionElement(element);

- if (!option.isDisabledFormControl() && !option.value().isEmpty())

- return true;

- }

- return false;

+ return isHTMLOptionElement(element);

}

} // namespace blink