Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(710)

Unified Diff: third_party/WebKit/Source/core/paint/ThemePainter.cpp

Issue 2746823002: Correct elementMatches filter for datalist.options (Closed)
Patch Set: Remove superfluous test, added filter to callees. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/forms/RangeInputType.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/ThemePainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/ThemePainter.cpp b/third_party/WebKit/Source/core/paint/ThemePainter.cpp
index 053313536e2eeceb74818ed8157adfbcb287afb4..20f5fd19623ff5a14d8c9a1e018132d4c70cc09b 100644
--- a/third_party/WebKit/Source/core/paint/ThemePainter.cpp
+++ b/third_party/WebKit/Source/core/paint/ThemePainter.cpp
@@ -327,6 +327,8 @@ void ThemePainter::paintSliderTicks(const LayoutObject& o,
for (unsigned i = 0; HTMLOptionElement* optionElement = options->item(i);
i++) {
String value = optionElement->value();
+ if (optionElement->isDisabledFormControl() || value.isEmpty())
+ continue;
if (!input->isValidValue(value))
continue;
double parsedValue =
« no previous file with comments | « third_party/WebKit/Source/core/html/forms/RangeInputType.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698