third_party/WebKit/Source/core/html/forms/ColorInputType.cpp - Issue 2746823002: Correct elementMatches filter for datalist.options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

Issue 2746823002: Correct elementMatches filter for datalist.options (Closed)

Patch Set: Remove superfluous test, added filter to callees. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp b/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

index 781068b56308a4b5afc9c3b21bd82902d791b59c..2905794cea86b8a8b6d5b26d85582bb005334ffa 100644

--- a/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/ColorInputType.cpp

@@ -245,6 +245,8 @@ Vector<ColorSuggestion> ColorInputType::suggestions() const {

if (dataList) {

HTMLDataListOptionsCollection* options = dataList->options();

for (unsigned i = 0; HTMLOptionElement* option = options->item(i); i++) {

+ if (option->isDisabledFormControl() || option->value().isEmpty())

+ continue;

if (!element().isValidValue(option->value()))

continue;

Color color;