third_party/WebKit/Source/core/html/forms/RangeInputType.cpp - Issue 2746823002: Correct elementMatches filter for datalist.options

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

Issue 2746823002: Correct elementMatches filter for datalist.options (Closed)

Patch Set: Remove superfluous test, added filter to callees. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

diff --git a/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp b/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

index 7d9016858096c90d26ba1bff7644678a89680f50..50eb0dd59db20d9a5d0a0a72b36aaf0bbaf611be 100644

--- a/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

+++ b/third_party/WebKit/Source/core/html/forms/RangeInputType.cpp

@@ -363,6 +363,8 @@ void RangeInputType::updateTickMarkValues() {

for (unsigned i = 0; i < options->length(); ++i) {

HTMLOptionElement* optionElement = options->item(i);

String optionValue = optionElement->value();

+ if (optionElement->isDisabledFormControl() || optionValue.isEmpty())

+ continue;

if (!this->element().isValidValue(optionValue))

continue;

m_tickMarkValues.push_back(parseToNumber(optionValue, Decimal::nan()));