[fasta] Add and correct even more offsets

[fasta] Add and correct even more offsets

E.g. kernel debugging of async functions should now work.

BUG=
R=ahe@google.com

Committed: https://github.com/dart-lang/sdk/commit/4d208e2ffb209373a07dff9a5f148b33c7356290

[jensj, 2017-03-13 14:17:00]

jensj@google.com changed reviewers:
+ ahe@google.com

[ahe, 2017-03-13 14:33:52]

Some preliminary comments.

https://codereview.chromium.org/2746013003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2746013003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:228: Block popBlock(int
count, Token beginToken) {
Should take an int, not a token.

https://codereview.chromium.org/2746013003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1691: Token nameToken =
token.next ?? token;
token.next can't be null.

https://codereview.chromium.org/2746013003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2746013003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:1294: start, getOrSet,
formalParametersToken, endToken);
Have you tested this situation:

get foo => "foo";

[jensj, 2017-03-14 12:37:12]

Thanks --- if you have a better name than 'formalParametersToken' to describe
the 'whatever is after the identifier and optional <whatnot> stuff, normally the
formal parameters but not necessarily' token situation I'm all ears :) (it's
only ever used to fill in functionNode.fileOffset, so maybe get rid of it as a
token and pass it as an int a la functionNodeCharOffset perhaps?)

https://codereview.chromium.org/2746013003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/kernel/body_builder.dart (right):

https://codereview.chromium.org/2746013003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:228: Block popBlock(int
count, Token beginToken) {
On 2017/03/13 14:33:52, ahe wrote:
> Should take an int, not a token.

Fixed.

https://codereview.chromium.org/2746013003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/kernel/body_builder.dart:1691: Token nameToken =
token.next ?? token;
On 2017/03/13 14:33:52, ahe wrote:
> token.next can't be null.

Acknowledged.

https://codereview.chromium.org/2746013003/diff/1/pkg/front_end/lib/src/fasta...
File pkg/front_end/lib/src/fasta/parser/parser.dart (right):

https://codereview.chromium.org/2746013003/diff/1/pkg/front_end/lib/src/fasta...
pkg/front_end/lib/src/fasta/parser/parser.dart:1294: start, getOrSet,
formalParametersToken, endToken);
On 2017/03/13 14:33:52, ahe wrote:
> Have you tested this situation:
> 
> get foo => "foo";

Well -- the name is misleading (the token is '=>') --- other than that I think
it's fine... I will add a service test that steps through such a thing though
(different CL).
Do you have an idea for a better name?

[jensj, 2017-03-20 11:55:11]

ping.

[jensj, 2017-03-20 14:44:55]

Patchset #4 (id:60001) has been deleted

[jensj, 2017-03-20 14:48:03]

With help from Peter, formalParametersToken parameter was removed --- pushing
position on stack instead.
PTAL.

[ahe, 2017-03-20 15:14:44]

lgtm

[jensj, 2017-03-21 09:57:37]

Description was changed from

==========
[fasta] Add and correct even more offsets

E.g. kernel debugging of async functions should now work.

BUG=
==========

to

==========
[fasta] Add and correct even more offsets

E.g. kernel debugging of async functions should now work.

BUG=
R=ahe@google.com

Committed:
https://github.com/dart-lang/sdk/commit/4d208e2ffb209373a07dff9a5f148b33c7356290
==========

[jensj, 2017-03-21 09:57:38]

Committed patchset #4 (id:80001) manually as
4d208e2ffb209373a07dff9a5f148b33c7356290 (presubmit successful).