Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(720)

Side by Side Diff: pkg/front_end/lib/src/fasta/source/source_library_builder.dart

Issue 2746013003: [fasta] Add and correct even more offsets (Closed)
Patch Set: Removed formalParametersToken parameter Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/front_end/lib/src/fasta/source/source_class_builder.dart ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.source_library_builder; 5 library fasta.source_library_builder;
6 6
7 import 'package:kernel/ast.dart' show AsyncMarker, ProcedureKind; 7 import 'package:kernel/ast.dart' show AsyncMarker, ProcedureKind;
8 8
9 import '../combinator.dart' show Combinator; 9 import '../combinator.dart' show Combinator;
10 10
(...skipping 183 matching lines...) Expand 10 before | Expand all | Expand 10 after
194 void addProcedure( 194 void addProcedure(
195 List<MetadataBuilder> metadata, 195 List<MetadataBuilder> metadata,
196 int modifiers, 196 int modifiers,
197 T returnType, 197 T returnType,
198 String name, 198 String name,
199 List<TypeVariableBuilder> typeVariables, 199 List<TypeVariableBuilder> typeVariables,
200 List<FormalParameterBuilder> formals, 200 List<FormalParameterBuilder> formals,
201 AsyncMarker asyncModifier, 201 AsyncMarker asyncModifier,
202 ProcedureKind kind, 202 ProcedureKind kind,
203 int charOffset, 203 int charOffset,
204 int charOpenParenOffset,
204 int charEndOffset, 205 int charEndOffset,
205 String nativeMethodName, 206 String nativeMethodName,
206 {bool isTopLevel}); 207 {bool isTopLevel});
207 208
208 void addEnum(List<MetadataBuilder> metadata, String name, 209 void addEnum(List<MetadataBuilder> metadata, String name,
209 List<String> constants, int charOffset, int charEndOffset); 210 List<String> constants, int charOffset, int charEndOffset);
210 211
211 void addFunctionTypeAlias( 212 void addFunctionTypeAlias(
212 List<MetadataBuilder> metadata, 213 List<MetadataBuilder> metadata,
213 T returnType, 214 T returnType,
214 String name, 215 String name,
215 List<TypeVariableBuilder> typeVariables, 216 List<TypeVariableBuilder> typeVariables,
216 List<FormalParameterBuilder> formals, 217 List<FormalParameterBuilder> formals,
217 int charOffset); 218 int charOffset);
218 219
219 FunctionTypeBuilder addFunctionType( 220 FunctionTypeBuilder addFunctionType(
220 T returnType, 221 T returnType,
221 List<TypeVariableBuilder> typeVariables, 222 List<TypeVariableBuilder> typeVariables,
222 List<FormalParameterBuilder> formals, 223 List<FormalParameterBuilder> formals,
223 int charOffset); 224 int charOffset);
224 225
225 void addFactoryMethod( 226 void addFactoryMethod(
226 List<MetadataBuilder> metadata, 227 List<MetadataBuilder> metadata,
227 int modifiers, 228 int modifiers,
228 ConstructorReferenceBuilder name, 229 ConstructorReferenceBuilder name,
229 List<FormalParameterBuilder> formals, 230 List<FormalParameterBuilder> formals,
230 AsyncMarker asyncModifier, 231 AsyncMarker asyncModifier,
231 ConstructorReferenceBuilder redirectionTarget, 232 ConstructorReferenceBuilder redirectionTarget,
232 int charOffset, 233 int charOffset,
234 int charOpenParenOffset,
233 int charEndOffset, 235 int charEndOffset,
234 String nativeMethodName); 236 String nativeMethodName);
235 237
236 FormalParameterBuilder addFormalParameter(List<MetadataBuilder> metadata, 238 FormalParameterBuilder addFormalParameter(List<MetadataBuilder> metadata,
237 int modifiers, T type, String name, bool hasThis, int charOffset); 239 int modifiers, T type, String name, bool hasThis, int charOffset);
238 240
239 TypeVariableBuilder addTypeVariable(String name, T bound, int charOffset); 241 TypeVariableBuilder addTypeVariable(String name, T bound, int charOffset);
240 242
241 Builder addBuilder(String name, Builder builder, int charOffset) { 243 Builder addBuilder(String name, Builder builder, int charOffset) {
242 if (name.indexOf(".") != -1 && name.indexOf("&") == -1) { 244 if (name.indexOf(".") != -1 && name.indexOf("&") == -1) {
(...skipping 277 matching lines...) Expand 10 before | Expand all | Expand 10 after
520 } 522 }
521 523
522 /// Called to register [procedure] as a factory whose types are collected in 524 /// Called to register [procedure] as a factory whose types are collected in
523 /// [factoryDeclaration]. Later, once the class has been built, we can 525 /// [factoryDeclaration]. Later, once the class has been built, we can
524 /// synthesize type variables on the factory matching the class'. 526 /// synthesize type variables on the factory matching the class'.
525 void addFactoryDeclaration( 527 void addFactoryDeclaration(
526 ProcedureBuilder procedure, DeclarationBuilder<T> factoryDeclaration) { 528 ProcedureBuilder procedure, DeclarationBuilder<T> factoryDeclaration) {
527 factoryDeclarations[procedure] = factoryDeclaration; 529 factoryDeclarations[procedure] = factoryDeclaration;
528 } 530 }
529 } 531 }
OLDNEW
« no previous file with comments | « pkg/front_end/lib/src/fasta/source/source_class_builder.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698