Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: pkg/front_end/lib/src/fasta/source/source_class_builder.dart

Issue 2746013003: [fasta] Add and correct even more offsets (Closed)
Patch Set: Removed formalParametersToken parameter Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2016, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library fasta.source_class_builder; 5 library fasta.source_class_builder;
6 6
7 import 'package:kernel/ast.dart' 7 import 'package:kernel/ast.dart'
8 show Class, Constructor, Supertype, TreeNode, setParents; 8 show Class, Constructor, Supertype, TreeNode, setParents;
9 9
10 import '../errors.dart' show internalError; 10 import '../errors.dart' show internalError;
(...skipping 14 matching lines...) Expand all
25 TypeVariableBuilder; 25 TypeVariableBuilder;
26 26
27 import '../dill/dill_member_builder.dart' show DillMemberBuilder; 27 import '../dill/dill_member_builder.dart' show DillMemberBuilder;
28 28
29 import '../util/relativize.dart' show relativizeUri; 29 import '../util/relativize.dart' show relativizeUri;
30 30
31 Class initializeClass( 31 Class initializeClass(
32 Class cls, String name, LibraryBuilder parent, int charOffset) { 32 Class cls, String name, LibraryBuilder parent, int charOffset) {
33 cls ??= new Class(name: name); 33 cls ??= new Class(name: name);
34 cls.fileUri ??= relativizeUri(parent.fileUri); 34 cls.fileUri ??= relativizeUri(parent.fileUri);
35 if (cls.fileOffset != TreeNode.noOffset) { 35 if (cls.fileOffset == TreeNode.noOffset) {
36 cls.fileOffset = charOffset; 36 cls.fileOffset = charOffset;
37 } 37 }
38 return cls; 38 return cls;
39 } 39 }
40 40
41 class SourceClassBuilder extends KernelClassBuilder { 41 class SourceClassBuilder extends KernelClassBuilder {
42 final Class cls; 42 final Class cls;
43 43
44 final Map<String, Builder> constructors; 44 final Map<String, Builder> constructors;
45 45
(...skipping 96 matching lines...) Expand 10 before | Expand all | Expand 10 after
142 Map<String, Builder> computeConstructors(Map<String, Builder> members) { 142 Map<String, Builder> computeConstructors(Map<String, Builder> members) {
143 Map<String, Builder> constructors = <String, Builder>{}; 143 Map<String, Builder> constructors = <String, Builder>{};
144 members.forEach((String name, Builder builder) { 144 members.forEach((String name, Builder builder) {
145 if (builder is ProcedureBuilder && 145 if (builder is ProcedureBuilder &&
146 (builder.isConstructor || builder.isFactory)) { 146 (builder.isConstructor || builder.isFactory)) {
147 constructors[name] = builder; 147 constructors[name] = builder;
148 } 148 }
149 }); 149 });
150 return constructors; 150 return constructors;
151 } 151 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698