Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: pkg/front_end/lib/src/fasta/parser/parser.dart

Issue 2746013003: [fasta] Add and correct even more offsets (Closed)
Patch Set: Removed formalParametersToken parameter Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/parser/parser.dart
diff --git a/pkg/front_end/lib/src/fasta/parser/parser.dart b/pkg/front_end/lib/src/fasta/parser/parser.dart
index 149b86c599880b840fa52a95003d254246d53757..770be1abb1bdc50fb8c476a8906e047068f698ec 100644
--- a/pkg/front_end/lib/src/fasta/parser/parser.dart
+++ b/pkg/front_end/lib/src/fasta/parser/parser.dart
@@ -542,6 +542,7 @@ class Parser {
bool isNamedParameter = kind == FormalParameterType.NAMED;
Token thisKeyword = null;
+ Token nameToken;
if (inFunctionType && isNamedParameter) {
token = parseType(token);
token =
@@ -559,8 +560,10 @@ class Parser {
if (optional('this', token)) {
thisKeyword = token;
token = expect('.', token.next);
+ nameToken = token;
token = parseIdentifier(token, IdentifierContext.fieldInitializer);
} else {
+ nameToken = token;
token = parseIdentifier(
token, IdentifierContext.formalParameterDeclaration);
}
@@ -609,7 +612,7 @@ class Parser {
} else {
listener.handleFormalParameterWithoutValue(token);
}
- listener.endFormalParameter(covariantKeyword, thisKeyword, kind);
+ listener.endFormalParameter(covariantKeyword, thisKeyword, nameToken, kind);
return token;
}
@@ -1948,6 +1951,7 @@ class Parser {
}
Token parseFunction(Token token, Token getOrSet) {
+ Token beginToken = token;
listener.beginFunction(token);
token = parseModifiers(token);
if (identical(getOrSet, token)) {
@@ -1982,7 +1986,7 @@ class Parser {
}
token = parseQualifiedRestOpt(
token, IdentifierContext.localFunctionDeclarationContinuation);
- listener.endFunctionName(token);
+ listener.endFunctionName(beginToken, token);
if (getOrSet == null) {
token = parseTypeVariablesOpt(token);
} else {
@@ -1999,6 +2003,7 @@ class Parser {
}
Token parseUnnamedFunction(Token token) {
+ Token beginToken = token;
listener.beginUnnamedFunction(token);
token = parseFormalParameters(token);
AsyncModifier savedAsyncModifier = asyncState;
@@ -2006,7 +2011,7 @@ class Parser {
bool isBlock = optional('{', token);
token = parseFunctionBody(token, true, false);
asyncState = savedAsyncModifier;
- listener.endUnnamedFunction(token);
+ listener.endUnnamedFunction(beginToken, token);
return isBlock ? token.next : token;
}
@@ -2018,12 +2023,13 @@ class Parser {
}
Token parseFunctionExpression(Token token) {
+ Token beginToken = token;
listener.beginFunction(token);
listener.handleModifiers(0);
token = parseReturnTypeOpt(token);
listener.beginFunctionName(token);
token = parseIdentifier(token, IdentifierContext.functionExpressionName);
- listener.endFunctionName(token);
+ listener.endFunctionName(beginToken, token);
token = parseTypeVariablesOpt(token);
token = parseFormalParameters(token);
listener.handleNoInitializers();
« no previous file with comments | « pkg/front_end/lib/src/fasta/parser/listener.dart ('k') | pkg/front_end/lib/src/fasta/source/outline_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698