Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart

Issue 2746013003: [fasta] Add and correct even more offsets (Closed)
Patch Set: Removed formalParametersToken parameter Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart
diff --git a/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart b/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart
index eea4554c4d0cf15d1c9673cd12ac9ba669764a58..4a93680141f02d7e50d4242801668cc6d365f7f8 100644
--- a/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart
+++ b/pkg/front_end/lib/src/fasta/kernel/frontend_accessors.dart
@@ -147,7 +147,7 @@ class PropertyAccessor extends Accessor {
static Accessor make(Expression receiver, Name name, Member getter,
Member setter, int charOffset) {
if (receiver is ThisExpression) {
- return new ThisPropertyAccessor(name, getter, setter);
+ return new ThisPropertyAccessor(name, getter, setter, charOffset);
} else {
return new PropertyAccessor.internal(
receiver, name, getter, setter, charOffset);
@@ -185,13 +185,16 @@ class PropertyAccessor extends Accessor {
class ThisPropertyAccessor extends Accessor {
Name name;
Member getter, setter;
+ final int charOffset;
- ThisPropertyAccessor(this.name, this.getter, this.setter);
+ ThisPropertyAccessor(this.name, this.getter, this.setter, this.charOffset);
- _makeRead() => new PropertyGet(new ThisExpression(), name, getter);
+ _makeRead() => new PropertyGet(new ThisExpression(), name, getter)
+ ..fileOffset = charOffset;
_makeWrite(Expression value, bool voidContext) {
- return new PropertySet(new ThisExpression(), name, value, setter);
+ return new PropertySet(new ThisExpression(), name, value, setter)
+ ..fileOffset = charOffset;
}
}
@@ -426,16 +429,18 @@ class SuperIndexAccessor extends Accessor {
class StaticAccessor extends Accessor {
Member readTarget;
Member writeTarget;
+ int charOffset;
- StaticAccessor(this.readTarget, this.writeTarget);
+ StaticAccessor(this.readTarget, this.writeTarget, this.charOffset);
_makeRead() =>
- readTarget == null ? makeInvalidRead() : new StaticGet(readTarget);
+ readTarget == null ? makeInvalidRead() : new StaticGet(readTarget)
+ ..fileOffset = charOffset;
_makeWrite(Expression value, bool voidContext) {
return writeTarget == null
? makeInvalidWrite(value)
- : new StaticSet(writeTarget, value);
+ : new StaticSet(writeTarget, value)..fileOffset = charOffset;
}
}
« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/builder_accessors.dart ('k') | pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698