pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart - Issue 2746013003: [fasta] Add and correct even more offsets

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart

Issue 2746013003: [fasta] Add and correct even more offsets (Closed)

Patch Set: Removed formalParametersToken parameter Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/front_end/lib/src/fasta/kernel/kernel_enum_builder.dart ('k') | pkg/front_end/lib/src/fasta/kernel/kernel_library_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart

diff --git a/pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart b/pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart

index 09bd87580f71a848ee4885b7c8461d516e248d8d..f7cb56094f117a27bef4fb26ae297db8e68ba14b 100644

--- a/pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart

+++ b/pkg/front_end/lib/src/fasta/kernel/kernel_formal_parameter_builder.dart

@@ -17,6 +17,7 @@ import 'kernel_builder.dart'

class KernelFormalParameterBuilder

extends FormalParameterBuilder<KernelTypeBuilder> {

VariableDeclaration declaration;

+ final int charOffset;

KernelFormalParameterBuilder(

List<MetadataBuilder> metadata,

@@ -25,7 +26,7 @@ class KernelFormalParameterBuilder

String name,

bool hasThis,

KernelLibraryBuilder compilationUnit,

- int charOffset)

+ this.charOffset)

: super(metadata, modifiers, type, name, hasThis, compilationUnit,

charOffset);

@@ -33,7 +34,7 @@ class KernelFormalParameterBuilder

return declaration ??= new VariableDeclaration(name,

type: type?.build(library) ?? const DynamicType(),

isFinal: isFinal,

- isConst: isConst);

+ isConst: isConst)..fileOffset = charOffset;

}

VariableDeclaration get target => declaration;