Revert of Reduce copying of local data structures in GeometryMapper and PaintLayerClipper.

Revert of Reduce copying of local data structures in GeometryMapper and PaintLayerClipper. (patchset #10 id:170001 of https://codereview.chromium.org/2745563004/ )

Reason for revert:
Speculative revert, it doesn't look related but am trying changes in the blame range.

Will update if the revert has changed things / will revert the revert otherwise.

https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds/9030

Test: SitePerProcessHighDPIExpiredCertBrowserTest.InterstitialLoadsWithCorrectDeviceScaleFactor

Original issue's description:
> Reduce copying of local data structures in GeometryMapper and PaintLayerClipper.
> 
> In particular, changes return values from FloatClipRect to const FloatClipRect&,
> to avoid extra data structure copies.
> 
> In local testing, this CL produces up to a 10% improvement on the
> rasterize_and_record_micro.partial_invalidation benchmark.
> 
> BUG=692614
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2745563004
> Cr-Commit-Position: refs/heads/master@{#456011}
> Committed: https://chromium.googlesource.com/chromium/src/+/05c00d2035047fa9d210d95afedf8bd063bccc33

TBR=pdr@chromium.org,wangxianzhu@chromium.org,chrishtr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=692614
Review-Url: https://codereview.chromium.org/2743733004
Cr-Commit-Position: refs/heads/master@{#456032}
Committed: https://chromium.googlesource.com/chromium/src/+/a2c9dcac6e64411adf0b6f047125d5ba415cce54

[kinuko, 2017-03-10 09:45:26]

The CQ bit was checked by kinuko@chromium.org

[kinuko, 2017-03-10 09:45:26]

Created Revert of Reduce copying of local data structures in GeometryMapper and
PaintLayerClipper.

[commit-bot: I haz the power, 2017-03-10 09:45:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-10 09:46:33]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1489139126477240, "parent_rev":
"165301f0f586d2cf00f5ca19678548693f9c19c2", "commit_rev":
"a2c9dcac6e64411adf0b6f047125d5ba415cce54"}

[commit-bot: I haz the power, 2017-03-10 09:47:14]

Description was changed from

==========
Revert of Reduce copying of local data structures in GeometryMapper and
PaintLayerClipper. (patchset #10 id:170001 of
https://codereview.chromium.org/2745563004/ )

Reason for revert:
Speculative revert, it doesn't look related but am trying changes in the blame
range.

Will update if the revert has changed things / will revert the revert otherwise.

https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds...

Test:
SitePerProcessHighDPIExpiredCertBrowserTest.InterstitialLoadsWithCorrectDeviceScaleFactor

Original issue's description:
> Reduce copying of local data structures in GeometryMapper and
PaintLayerClipper.
> 
> In particular, changes return values from FloatClipRect to const
FloatClipRect&,
> to avoid extra data structure copies.
> 
> In local testing, this CL produces up to a 10% improvement on the
> rasterize_and_record_micro.partial_invalidation benchmark.
> 
> BUG=692614
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2745563004
> Cr-Commit-Position: refs/heads/master@{#456011}
> Committed:
https://chromium.googlesource.com/chromium/src/+/05c00d2035047fa9d210d95afedf...

TBR=pdr@chromium.org,wangxianzhu@chromium.org,chrishtr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=692614
==========

to

==========
Revert of Reduce copying of local data structures in GeometryMapper and
PaintLayerClipper. (patchset #10 id:170001 of
https://codereview.chromium.org/2745563004/ )

Reason for revert:
Speculative revert, it doesn't look related but am trying changes in the blame
range.

Will update if the revert has changed things / will revert the revert otherwise.

https://build.chromium.org/p/chromium.win/builders/Win10%20Tests%20x64/builds...

Test:
SitePerProcessHighDPIExpiredCertBrowserTest.InterstitialLoadsWithCorrectDeviceScaleFactor

Original issue's description:
> Reduce copying of local data structures in GeometryMapper and
PaintLayerClipper.
> 
> In particular, changes return values from FloatClipRect to const
FloatClipRect&,
> to avoid extra data structure copies.
> 
> In local testing, this CL produces up to a 10% improvement on the
> rasterize_and_record_micro.partial_invalidation benchmark.
> 
> BUG=692614
>
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
> 
> Review-Url: https://codereview.chromium.org/2745563004
> Cr-Commit-Position: refs/heads/master@{#456011}
> Committed:
https://chromium.googlesource.com/chromium/src/+/05c00d2035047fa9d210d95afedf...

TBR=pdr@chromium.org,wangxianzhu@chromium.org,chrishtr@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=692614

Review-Url: https://codereview.chromium.org/2743733004
Cr-Commit-Position: refs/heads/master@{#456032}
Committed:
https://chromium.googlesource.com/chromium/src/+/a2c9dcac6e64411adf0b6f047125...
==========

[commit-bot: I haz the power, 2017-03-10 09:47:15]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/a2c9dcac6e64411adf0b6f047125...

[kinuko, 2017-03-10 10:33:19]

Looks like the test's just flaky, I'll mark the test and revert this one.

[kinuko, 2017-03-10 10:33:45]

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2741103005/ by kinuko@chromium.org.

The reason for reverting is: Was likely a false alarm..