third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp - Issue 2743733004: Revert of Reduce copying of local data structures in GeometryMapper and PaintLayerClipper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

Issue 2743733004: Revert of Reduce copying of local data structures in GeometryMapper and PaintLayerClipper. (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/compositing/CompositedLayerMapping.cpp ('k') | third_party/WebKit/Source/core/paint/ClipRect.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

index 53d5dfb1acd5d8d7b2625c133039496d26ee4999..ae0dcc65cc9ceae71c10d3c3b75440b14e1082e9 100644

--- a/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingInputsUpdater.cpp

@@ -161,14 +161,14 @@

if (properties.unclippedAbsoluteBoundingBox.isEmpty())

properties.unclippedAbsoluteBoundingBox.setSize(IntSize(1, 1));

- ClipRect clipRect;

- layer->clipper(PaintLayer::DoNotUseGeometryMapper)

- .calculateBackgroundClipRect(

- ClipRectsContext(m_rootLayer, AbsoluteClipRects), clipRect);

- IntRect snappedClipRect = pixelSnappedIntRect(clipRect.rect());

+ IntRect clipRect = pixelSnappedIntRect(

+ layer->clipper(PaintLayer::DoNotUseGeometryMapper)

+ .backgroundClipRect(

+ ClipRectsContext(m_rootLayer, AbsoluteClipRects))

+ .rect());

properties.clippedAbsoluteBoundingBox =

properties.unclippedAbsoluteBoundingBox;

- properties.clippedAbsoluteBoundingBox.intersect(snappedClipRect);

+ properties.clippedAbsoluteBoundingBox.intersect(clipRect);

}

const PaintLayer* parent = layer->parent();