Clean up cc/paint interfaces

Clean up cc/paint interfaces

Remove unused functions and merge duplicates.  Also, make all functions that
may take ownership of objects use sk_sp<Object> parameters.

TBR=junov@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2743363006
Cr-Commit-Position: refs/heads/master@{#458150}
Committed: https://chromium.googlesource.com/chromium/src/+/8c44b140cee7a5989c1e2e8fd52267e27332564d

[enne (OOO), 2017-03-15 00:44:25]

Description was changed from

==========
[wip] clean up cc/paint interfaces
==========

to

==========
[wip] clean up cc/paint interfaces
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[enne (OOO), 2017-03-15 00:44:26]

Description was changed from

==========
[wip] clean up cc/paint interfaces
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
[wip] clean up cc/paint interfaces
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[enne (OOO), 2017-03-15 18:34:15]

Description was changed from

==========
[wip] clean up cc/paint interfaces
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Clean up cc/paint interfaces

Remove unused functions and merge duplicates.  Also, make all functions that
may take ownership of objects use sk_sp<Object> parameters.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[enne (OOO), 2017-03-15 18:34:15]

enne@chromium.org changed reviewers:
+ vmpstr@chromium.org

[enne (OOO), 2017-03-15 22:32:27]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 22:33:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2017-03-16 19:06:15]

The CQ bit was checked by enne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-16 19:07:01]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[enne (OOO), 2017-03-16 19:12:08]

enne@chromium.org changed reviewers:
+ danakj@chromium.org, pdr@chromium.org, watk@chromium.org

[enne (OOO), 2017-03-16 19:14:49]

enne@chromium.org changed reviewers:
+ junov@chromium.org

[enne (OOO), 2017-03-16 19:14:50]

danakj/vmpstr (one of you or both): overall
pdr: mechanical Blink stuff
junov: minor canvas header change
watk: minor media change

[pdr., 2017-03-16 19:52:56]

On 2017/03/16 at 19:14:50, enne wrote:
> danakj/vmpstr (one of you or both): overall
> pdr: mechanical Blink stuff
> junov: minor canvas header change
> watk: minor media change

LGTM for the blink parts. Leaving the real review to danakj and vmpstr

[danakj, 2017-03-16 20:06:17]

The cc changes LGTM I just have a bunch of comments on the code that now has
refptrs and is passing ownership.

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/ClipPathClipper.cpp (right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/ClipPathClipper.cpp:215:
m_context.drawRecord(maskPaintRecord);
move(), or just pass endRecording() directly

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/paint/SVGMaskPainter.cpp (right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/paint/SVGMaskPainter.cpp:84:
context.drawRecord(record);
move()

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/BitmapImage.cpp (right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/BitmapImage.cpp:301:
canvas->drawImageRect(image, adjustedSrcRect, adjustedDstRect, &flags,
if you grab the lazygen and uniqueid, you could move here

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/BoxReflection.h (right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/BoxReflection.h:40:
sk_sp<PaintRecord> mask() const { return m_mask; }
const& for returning so u can mask()->thing without reffing

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp
(right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp:189:
tempCanvas->drawImage(image, 0, 0);
move()

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp:197:
tempCanvas->drawImage(image, 0, 0);
move()

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp:220:
tempCanvas->drawImage(image, 0, 0);
move()

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/DeferredImageDecoderTest.cpp:319:
tempCanvas->drawImage(image, 0, 0);
move()

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp (right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/GraphicsContext.cpp:305:
m_canvas->drawPicture(record);
move()

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp
(right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp:85:
canvas.drawPicture(record);
move() or pass endRecording() directly. the variable lvalue is not used

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp:95:
canvas.drawPicture(record);
same

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp:128:
canvas.drawPicture(record);
same

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/GraphicsContextTest.cpp:146:
canvas.drawPicture(record);
same same

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp (right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp:1238:
canvas.drawPicture(newRecord);
move

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/Image.cpp (right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/Image.cpp:241:
canvas->drawImage(image, 0, 0, &paint);
move()

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/Image.cpp:313:
createPatternShader(image, localMatrix, flags,
move()

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp (right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/ImageBuffer.cpp:573:
surface->canvas()->drawImage(image, 0, 0);
move()

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/StaticBitmapImage.cpp (right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/StaticBitmapImage.cpp:38:
canvas->drawImageRect(image, adjustedSrcRect, dstRect, &flags,
move()

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp
(right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp:195:
list->CreateAndAppendDrawingItem<cc::DrawingDisplayItem>(largeRect, record);
move()

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp
(right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp:151:
SkPictureImageFilter::Make(ToSkPicture(maskRecord)), input,
move()

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp
(right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/DisplayItemList.cpp:95:
static_cast<const DrawingDisplayItem&>(displayItem)
a temp var here could go a long way to less wild line wrapping, maybe for the
item cast?

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
(right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp:56:
static bool recordsEqual(sk_sp<const PaintRecord> record1,
This seems like it should be T* still? ToSkPicture isn't keeping ownership and
we're not storing it's result just using it as a temporary

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp:62:
sk_sp<SkData> data1 = ToSkPicture(record1)->serialize();
move()

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp:63:
sk_sp<SkData> data2 = ToSkPicture(record2)->serialize();
move()

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp:74:
canvas.drawPicture(record);
mvoe()

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp:78:
static bool bitmapsEqual(sk_sp<const PaintRecord> record1,
This seems like it should be T* also, it's not passing the ownership anywhere

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp:84:
SkBitmap bitmap1 = recordToBitmap(record1);
move()

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp:85:
SkBitmap bitmap2 = recordToBitmap(record2);
move()

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp:110:
sk_sp<const PaintRecord> record = this->GetPaintRecord();
const& probably?

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h
(right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h:37:
sk_sp<const PaintRecord> GetPaintRecord() const { return m_record; }
const&

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp
(right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:770:
newItem.isDrawing() ? static_cast<const DrawingDisplayItem&>(newItem)
maybe a ternary isnt the ring thing here and just

newRecord = nullptr;
if (isDrawing)
  newRecord = thing;

cuz this is a long ternary now

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp:774: const
PaintRecord* oldRecord =
same

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
(right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp:801:
sk_sp<const PaintRecord> firstPaintRecord =
could be const& if u want

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp:805:
sk_sp<const PaintRecord> secondPaintRecord =
same

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp:1595:
sk_sp<const PaintRecord> record1 =
same

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp:1718:
sk_sp<const PaintRecord> record0 =
same

[enne (OOO), 2017-03-16 20:57:27]

danakj: thanks for the thorough review.  I made all your requested changes,
except:

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
(right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp:56:
static bool recordsEqual(sk_sp<const PaintRecord> record1,
On 2017/03/16 at 20:06:16, danakj wrote:
> This seems like it should be T* still? ToSkPicture isn't keeping ownership and
we're not storing it's result just using it as a temporary

Agreed here.

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp:78:
static bool bitmapsEqual(sk_sp<const PaintRecord> record1,
On 2017/03/16 at 20:06:17, danakj wrote:
> This seems like it should be T* also, it's not passing the ownership anywhere

Not agreed here.  This is rasterizing via drawPicture which in this patch takes
an sk_sp.  Sure, the SkiaPaintCanvas doesn't take ownership of the PaintRecord
when rasterizing, but the recording version does, and at the PaintCanvas
interface level, I think you don't know that?

[danakj, 2017-03-16 21:02:02]

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
(right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp:78:
static bool bitmapsEqual(sk_sp<const PaintRecord> record1,
On 2017/03/16 20:57:26, enne wrote:
> On 2017/03/16 at 20:06:17, danakj wrote:
> > This seems like it should be T* also, it's not passing the ownership
anywhere
> 
> Not agreed here.  This is rasterizing via drawPicture which in this patch
takes
> an sk_sp.  Sure, the SkiaPaintCanvas doesn't take ownership of the PaintRecord
> when rasterizing, but the recording version does, and at the PaintCanvas
> interface level, I think you don't know that?

Oh ok I missed what recordToBitmap does.

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp:124:
return bitmapsEqual(record, otherRecord);
Then these would be move()s

[enne (OOO), 2017-03-16 21:06:33]

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp
(right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp:124:
return bitmapsEqual(record, otherRecord);
On 2017/03/16 at 21:02:01, danakj wrote:
> Then these would be move()s

Quite right.

[watk, 2017-03-16 22:50:50]

media lgtm

[enne (OOO), 2017-03-17 16:39:10]

Description was changed from

==========
Clean up cc/paint interfaces

Remove unused functions and merge duplicates.  Also, make all functions that
may take ownership of objects use sk_sp<Object> parameters.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Clean up cc/paint interfaces

Remove unused functions and merge duplicates.  Also, make all functions that
may take ownership of objects use sk_sp<Object> parameters.

TBR=junov@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[enne (OOO), 2017-03-17 16:39:27]

TBRing junov

[enne (OOO), 2017-03-17 16:39:31]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2017-03-17 16:39:31]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
pdr@chromium.org, watk@chromium.org
Link to the patchset: https://codereview.chromium.org/2743363006/#ps120001
(title: "Rebase")

[commit-bot: I haz the power, 2017-03-17 16:39:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 17:14:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 17:14:02]

Try jobs failed on following builders:
  linux_trusty_blink_rel on master.tryserver.blink (JOB_FAILED,
http://build.chromium.org/p/tryserver.blink/builders/linux_trusty_blink_rel/b...)

[enne (OOO), 2017-03-17 21:44:23]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2017-03-17 21:44:23]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
watk@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2743363006/#ps140001
(title: "Fix PaintControllerTest, BitmapImage crash")

[commit-bot: I haz the power, 2017-03-17 21:45:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 23:43:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-17 23:43:05]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[enne (OOO), 2017-03-20 17:14:15]

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp
(right):

https://codereview.chromium.org/2743363006/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/paint/PaintControllerTest.cpp:801:
sk_sp<const PaintRecord> firstPaintRecord =
On 2017/03/16 at 20:06:17, danakj wrote:
> could be const& if u want

ASAN disagrees:
https://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium...

I think I could make it a pointer, but why should a test author have to think
that strongly about lifetimes here.  I'm just going to leave it as it was
originally so lifetimes are preserved regardless.

[enne (OOO), 2017-03-20 17:14:34]

The CQ bit was checked by enne@chromium.org

[enne (OOO), 2017-03-20 17:14:35]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
watk@chromium.org, pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2743363006/#ps160001
(title: "Fix PaintControllerTest v2")

[commit-bot: I haz the power, 2017-03-20 17:15:05]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-20 19:34:35]

CQ is committing da patch.

Bot data: {"patchset_id": 160001, "attempt_start_ts": 1490030074796070,
"parent_rev": "2375e6dc4842a87abb21b9f1908fdcd3966ae54c", "commit_rev":
"8c44b140cee7a5989c1e2e8fd52267e27332564d"}

[commit-bot: I haz the power, 2017-03-20 19:35:49]

Description was changed from

==========
Clean up cc/paint interfaces

Remove unused functions and merge duplicates.  Also, make all functions that
may take ownership of objects use sk_sp<Object> parameters.

TBR=junov@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Clean up cc/paint interfaces

Remove unused functions and merge duplicates.  Also, make all functions that
may take ownership of objects use sk_sp<Object> parameters.

TBR=junov@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2743363006
Cr-Commit-Position: refs/heads/master@{#458150}
Committed:
https://chromium.googlesource.com/chromium/src/+/8c44b140cee7a5989c1e2e8fd522...
==========

[commit-bot: I haz the power, 2017-03-20 19:35:54]

Committed patchset #9 (id:160001) as
https://chromium.googlesource.com/chromium/src/+/8c44b140cee7a5989c1e2e8fd522...