Clean up cc/paint interfaces

third_party/WebKit/Source/platform/graphics/BoxReflection.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef BoxReflection_h
 #define BoxReflection_h
 
 #include "platform/PlatformExport.h"
 #include "platform/graphics/paint/PaintRecord.h"
 #include "third_party/skia/include/core/SkRefCnt.h"
@@ skipping 19 matching lines @@
     HorizontalReflection,
   };
 
   BoxReflection(ReflectionDirection direction,
                 float offset,
                 sk_sp<PaintRecord> mask = nullptr)
       : m_direction(direction), m_offset(offset), m_mask(std::move(mask)) {}
 
   ReflectionDirection direction() const { return m_direction; }
   float offset() const { return m_offset; }
-  PaintRecord* mask() const { return m_mask.get(); }
+  sk_sp<PaintRecord> mask() const { return m_mask; }

[danakj, 2017/03/16 20:06:15]

const& for returning so u can mask()->thing without reffing

 
   // Returns a matrix which maps points between the original content and its
   // reflection. Reflections are self-inverse, so this matrix can be used to
   // map in either direction.
   SkMatrix reflectionMatrix() const;
 
   // Maps a source rectangle to the destination rectangle it can affect,
   // including this reflection. Due to the symmetry of reflections, this can
   // also be used to map from a destination rectangle to the source rectangle
   // which contributes to it.
@@ skipping 10 matching lines @@
          a.mask() == b.mask();
 }
 
 inline bool operator!=(const BoxReflection& a, const BoxReflection& b) {
   return !(a == b);
 }
 
 }  // namespace blink
 
 #endif  // BoxReflection_h