third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp - Issue 2743363006: Clean up cc/paint interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp

Issue 2743363006: Clean up cc/paint interfaces (Closed)

Patch Set: Fix PaintControllerTest v2 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/StaticBitmapImage.cpp ('k') | third_party/WebKit/Source/platform/graphics/filters/SkiaImageFilterBuilder.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp b/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp

index 299c89adeb465eb7b4baa0a9a693e8bfafc12825..0d3fd717efb7d4de8266008772d6e87c9aa5290a 100644

--- a/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp

+++ b/third_party/WebKit/Source/platform/graphics/compositing/PaintChunksToCcLayer.cpp

@@ -182,7 +182,7 @@ static gfx::Rect largeRect(-200000, -200000, 400000, 400000);

static void appendDisplayItemToCcDisplayItemList(const DisplayItem& displayItem,

cc::DisplayItemList* list) {

if (DisplayItem::isDrawingType(displayItem.getType())) {

- const PaintRecord* record =

+ sk_sp<const PaintRecord> record =

static_cast<const DrawingDisplayItem&>(displayItem).GetPaintRecord();

if (!record)

return;

@@ -193,7 +193,7 @@ static void appendDisplayItemToCcDisplayItemList(const DisplayItem& displayItem,

// reworking visual rects further for SPv2, so for now we just pass a

// visual rect large enough to make sure items raster.

list->CreateAndAppendDrawingItem<cc::DrawingDisplayItem>(largeRect,

- sk_ref_sp(record));

+ std::move(record));

}