third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp - Issue 2743363006: Clean up cc/paint interfaces

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp

Issue 2743363006: Clean up cc/paint interfaces (Closed)

Patch Set: Fix PaintControllerTest v2 Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.cpp ('k') | third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp

diff --git a/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp b/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp

index 20477fa6aaed8e2affdfd3db480b5146ba8e4ea8..8e1d79b9b1be2af718a1fb8673ec45805c9dee55 100644

--- a/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp

+++ b/third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp

@@ -25,7 +25,7 @@ void computeChunkBoundsAndOpaqueness(const DisplayItemList& displayItems,

if (!item.isDrawing())

continue;

const auto& drawing = static_cast<const DrawingDisplayItem&>(item);

- if (const PaintRecord* record = drawing.GetPaintRecord()) {

+ if (const PaintRecord* record = drawing.GetPaintRecord().get()) {

if (drawing.knownToBeOpaque()) {

// TODO(pdr): It may be too conservative to round in to the

// enclosedIntRect.