Renamed WasWithinSamePage to WasWithinSameDocument.

Renamed NavigationState::WasWithinSamePage to WasWithinSameDocument.

Also renamed was_within_same_page IPC message to was_within_same_document
and NavigationState::WasWithinSameDocument to WasWithinSamePage

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2741313002
Cr-Commit-Position: refs/heads/master@{#457806}
Committed: https://chromium.googlesource.com/chromium/src/+/cf731b5cfca8a5d9d58493c43224a0274b564432

[Eugene But (OOO till 7-30), 2017-03-11 01:11:52]

Description was changed from

==========
Renamed WasWithinSamePage to WasWithinSameDocument.

BUG=695189
==========

to

==========
Renamed WasWithinSamePage to WasWithinSameDocument.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Eugene But (OOO till 7-30), 2017-03-11 01:12:03]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-11 01:12:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-11 01:17:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-11 01:17:58]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Eugene But (OOO till 7-30), 2017-03-14 02:09:08]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 02:10:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 02:18:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 02:18:36]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eugene But (OOO till 7-30), 2017-03-14 17:28:16]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 17:28:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 18:05:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 18:05:27]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Eugene But (OOO till 7-30), 2017-03-14 20:25:49]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-14 20:26:35]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-14 21:18:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-14 21:18:41]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-03-14 21:26:46]

Description was changed from

==========
Renamed WasWithinSamePage to WasWithinSameDocument.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Renamed NavigationState::WasWithinSamePage to WasWithinSameDocument.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Eugene But (OOO till 7-30), 2017-03-14 21:27:40]

Description was changed from

==========
Renamed NavigationState::WasWithinSamePage to WasWithinSameDocument.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Renamed NavigationState::WasWithinSamePage to WasWithinSameDocument.

Also renamed was_within_same_page IPC message to was_within_same_document.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Eugene But (OOO till 7-30), 2017-03-14 21:28:01]

eugenebut@chromium.org changed reviewers:
+ creis@chromium.org

[Eugene But (OOO till 7-30), 2017-03-14 21:28:02]

PTAL

[Charlie Reis, 2017-03-15 02:43:11]

Thanks!  LGTM with nits.

https://codereview.chromium.org/2741313002/diff/60001/chrome/renderer/safe_br...
File chrome/renderer/safe_browsing/phishing_classifier_delegate.cc (right):

https://codereview.chromium.org/2741313002/diff/60001/chrome/renderer/safe_br...
chrome/renderer/safe_browsing/phishing_classifier_delegate.cc:147: bool
/*is_same_page_navigation*/) {
Let's leave this change out.  It's unrelated, and I think it's uncommon in
Chrome code (relative to Blink).

(I also assume we'll change the name of this parameter in RenderFrameObserver in
a followup CL.)

https://codereview.chromium.org/2741313002/diff/60001/chrome/renderer/safe_br...
chrome/renderer/safe_browsing/phishing_classifier_delegate.cc:152: // is within
the same page.  However, if we let classification continue in
s/page/document/

https://codereview.chromium.org/2741313002/diff/60001/chrome/renderer/safe_br...
chrome/renderer/safe_browsing/phishing_classifier_delegate.cc:154: // be called
again for the in-page navigation.  We need to be sure not to
s/in-page/same-document/

https://codereview.chromium.org/2741313002/diff/60001/content/browser/frame_h...
File content/browser/frame_host/navigator_impl.cc (right):

https://codereview.chromium.org/2741313002/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigator_impl.cc:579: // Don't take screenshots if
we are staying on the same page. We want
s/page/document/

https://codereview.chromium.org/2741313002/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigator_impl.cc:580: // in-page navigations to be
super fast, and taking a screenshot
s/in-page/same-document/

https://codereview.chromium.org/2741313002/diff/60001/content/browser/frame_h...
File content/browser/frame_host/render_frame_host_impl.cc (right):

https://codereview.chromium.org/2741313002/diff/60001/content/browser/frame_h...
content/browser/frame_host/render_frame_host_impl.cc:3399: // entry. This is the
case for a browser-initiated same-page navigation,
s/same-page/same-document/

https://codereview.chromium.org/2741313002/diff/60001/content/browser/web_con...
File content/browser/web_contents/web_contents_view_aura_browsertest.cc (right):

https://codereview.chromium.org/2741313002/diff/60001/content/browser/web_con...
content/browser/web_contents/web_contents_view_aura_browsertest.cc:711: //
EXPECT_FALSE(screenshot_manager()->screenshot_taken_for());
I assume this still fails if we uncomment it?  (Might be nice to uncomment if it
works today, admittedly in a separate CL.)  :)

https://codereview.chromium.org/2741313002/diff/60001/content/common/frame_me...
File content/common/frame_messages.h (right):

https://codereview.chromium.org/2741313002/diff/60001/content/common/frame_me...
content/common/frame_messages.h:247: // the page. For example, the navigation
may have just resulted in scrolling
Heh, this sentence is all kinds of confusing.  :)  Let's say "no change of the
document within the frame."

https://codereview.chromium.org/2741313002/diff/60001/content/public/test/nav...
File content/public/test/navigation_simulator.cc (right):

https://codereview.chromium.org/2741313002/diff/60001/content/public/test/nav...
content/public/test/navigation_simulator.cc:411: void
NavigationSimulator::CommitSamePage() {
Looks like there's only one caller of this.  Want to update it to
CommitSameDocument in this CL as well?

https://codereview.chromium.org/2741313002/diff/60001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2741313002/diff/60001/content/renderer/render...
content/renderer/render_frame_impl.cc:4004:
UpdateNavigationState(document_state, true /* was_within_same_page */,
You're planning to update this (and the method name) in a later CL, right?

[Eugene But (OOO till 7-30), 2017-03-15 16:13:16]

The CQ bit was checked by eugenebut@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-15 16:13:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eugene But (OOO till 7-30), 2017-03-15 16:15:44]

Description was changed from

==========
Renamed NavigationState::WasWithinSamePage to WasWithinSameDocument.

Also renamed was_within_same_page IPC message to was_within_same_document.

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Renamed NavigationState::WasWithinSamePage to WasWithinSameDocument.

Also renamed was_within_same_page IPC message to was_within_same_document
and NavigationState::WasWithinSameDocument to WasWithinSamePage

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[Eugene But (OOO till 7-30), 2017-03-15 16:16:15]

eugenebut@chromium.org changed reviewers:
+ melandory@chromium.org

[Eugene But (OOO till 7-30), 2017-03-15 16:16:17]

Thanks!

+melandory for components/subresource_filter
+mattm for chrome/renderer/safe_browsing

https://codereview.chromium.org/2741313002/diff/60001/chrome/renderer/safe_br...
File chrome/renderer/safe_browsing/phishing_classifier_delegate.cc (right):

https://codereview.chromium.org/2741313002/diff/60001/chrome/renderer/safe_br...
chrome/renderer/safe_browsing/phishing_classifier_delegate.cc:147: bool
/*is_same_page_navigation*/) {
On 2017/03/15 02:43:10, Charlie Reis (slow) wrote:
> Let's leave this change out.  It's unrelated, and I think it's uncommon in
> Chrome code (relative to Blink).
> 
> (I also assume we'll change the name of this parameter in RenderFrameObserver
in
> a followup CL.)

Done.

https://codereview.chromium.org/2741313002/diff/60001/chrome/renderer/safe_br...
chrome/renderer/safe_browsing/phishing_classifier_delegate.cc:152: // is within
the same page.  However, if we let classification continue in
On 2017/03/15 02:43:10, Charlie Reis (slow) wrote:
> s/page/document/

Done.

https://codereview.chromium.org/2741313002/diff/60001/chrome/renderer/safe_br...
chrome/renderer/safe_browsing/phishing_classifier_delegate.cc:154: // be called
again for the in-page navigation.  We need to be sure not to
On 2017/03/15 02:43:10, Charlie Reis (slow) wrote:
> s/in-page/same-document/

Done.

https://codereview.chromium.org/2741313002/diff/60001/content/browser/frame_h...
File content/browser/frame_host/navigator_impl.cc (right):

https://codereview.chromium.org/2741313002/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigator_impl.cc:579: // Don't take screenshots if
we are staying on the same page. We want
On 2017/03/15 02:43:10, Charlie Reis (slow) wrote:
> s/page/document/

Done.

https://codereview.chromium.org/2741313002/diff/60001/content/browser/frame_h...
content/browser/frame_host/navigator_impl.cc:580: // in-page navigations to be
super fast, and taking a screenshot
On 2017/03/15 02:43:10, Charlie Reis (slow) wrote:
> s/in-page/same-document/

Done.

https://codereview.chromium.org/2741313002/diff/60001/content/browser/frame_h...
File content/browser/frame_host/render_frame_host_impl.cc (right):

https://codereview.chromium.org/2741313002/diff/60001/content/browser/frame_h...
content/browser/frame_host/render_frame_host_impl.cc:3399: // entry. This is the
case for a browser-initiated same-page navigation,
On 2017/03/15 02:43:10, Charlie Reis (slow) wrote:
> s/same-page/same-document/

Done.

https://codereview.chromium.org/2741313002/diff/60001/content/browser/web_con...
File content/browser/web_contents/web_contents_view_aura_browsertest.cc (right):

https://codereview.chromium.org/2741313002/diff/60001/content/browser/web_con...
content/browser/web_contents/web_contents_view_aura_browsertest.cc:711: //
EXPECT_FALSE(screenshot_manager()->screenshot_taken_for());
On 2017/03/15 02:43:10, Charlie Reis (slow) wrote:
> I assume this still fails if we uncomment it?  (Might be nice to uncomment if
it
> works today, admittedly in a separate CL.)  :)
Filed crbug.com/701801 for this.

https://codereview.chromium.org/2741313002/diff/60001/content/common/frame_me...
File content/common/frame_messages.h (right):

https://codereview.chromium.org/2741313002/diff/60001/content/common/frame_me...
content/common/frame_messages.h:247: // the page. For example, the navigation
may have just resulted in scrolling
On 2017/03/15 02:43:10, Charlie Reis (slow) wrote:
> Heh, this sentence is all kinds of confusing.  :)  Let's say "no change of the
> document within the frame."

Done.

https://codereview.chromium.org/2741313002/diff/60001/content/public/test/nav...
File content/public/test/navigation_simulator.cc (right):

https://codereview.chromium.org/2741313002/diff/60001/content/public/test/nav...
content/public/test/navigation_simulator.cc:411: void
NavigationSimulator::CommitSamePage() {
On 2017/03/15 02:43:10, Charlie Reis (slow) wrote:
> Looks like there's only one caller of this.  Want to update it to
> CommitSameDocument in this CL as well?

Done.

https://codereview.chromium.org/2741313002/diff/60001/content/renderer/render...
File content/renderer/render_frame_impl.cc (right):

https://codereview.chromium.org/2741313002/diff/60001/content/renderer/render...
content/renderer/render_frame_impl.cc:4004:
UpdateNavigationState(document_state, true /* was_within_same_page */,
On 2017/03/15 02:43:10, Charlie Reis (slow) wrote:
> You're planning to update this (and the method name) in a later CL, right?
Yes. There are many |SamePage| and |same_page| names in Chromium code and my
goal is to fix all of them. I'll probably get old by the time I finish :)

[melandory, 2017-03-15 16:26:31]

lgtm

[commit-bot: I haz the power, 2017-03-15 17:41:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-15 17:41:19]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-03-16 20:15:21]

eugenebut@chromium.org changed reviewers:
+ mattm@chromium.org

[Eugene But (OOO till 7-30), 2017-03-16 20:15:22]

Actually adding mattm@ for for chrome/renderer/safe_browsing

[mattm, 2017-03-16 22:03:33]

safe_browsing lgtm

[Eugene But (OOO till 7-30), 2017-03-16 22:10:45]

The CQ bit was checked by eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2017-03-16 22:10:46]

The patchset sent to the CQ was uploaded after l-g-t-m from creis@chromium.org
Link to the patchset: https://codereview.chromium.org/2741313002/#ps80001
(title: "Addressed review comments")

[commit-bot: I haz the power, 2017-03-16 22:11:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-16 22:20:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-16 22:21:00]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Eugene But (OOO till 7-30), 2017-03-17 00:28:46]

eugenebut@chromium.org changed reviewers:
+ jln@chromium.org

[Eugene But (OOO till 7-30), 2017-03-17 00:28:47]

+jln@chromium.org for content/common

[Charlie Reis, 2017-03-17 01:17:24]

creis@chromium.org changed reviewers:
+ nasko@chromium.org

[Charlie Reis, 2017-03-17 01:17:25]

nasko's probably a quicker reviewer for an IPC review of frame_messages.h.

[nasko, 2017-03-17 16:22:07]

IPC rubberstamp LGTM.

[Eugene But (OOO till 7-30), 2017-03-17 16:47:42]

The CQ bit was checked by eugenebut@chromium.org

[commit-bot: I haz the power, 2017-03-17 16:48:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-17 17:36:39]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1489769262103500,
"parent_rev": "8e89131b44e689b9992daad893367826ef25616f", "commit_rev":
"cf731b5cfca8a5d9d58493c43224a0274b564432"}

[commit-bot: I haz the power, 2017-03-17 17:37:21]

Description was changed from

==========
Renamed NavigationState::WasWithinSamePage to WasWithinSameDocument.

Also renamed was_within_same_page IPC message to was_within_same_document
and NavigationState::WasWithinSameDocument to WasWithinSamePage

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Renamed NavigationState::WasWithinSamePage to WasWithinSameDocument.

Also renamed was_within_same_page IPC message to was_within_same_document
and NavigationState::WasWithinSameDocument to WasWithinSamePage

BUG=695189
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation

Review-Url: https://codereview.chromium.org/2741313002
Cr-Commit-Position: refs/heads/master@{#457806}
Committed:
https://chromium.googlesource.com/chromium/src/+/cf731b5cfca8a5d9d58493c43224...
==========

[commit-bot: I haz the power, 2017-03-17 17:37:22]

Committed patchset #5 (id:80001) as
https://chromium.googlesource.com/chromium/src/+/cf731b5cfca8a5d9d58493c43224...