components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc - Issue 2741313002: Renamed WasWithinSamePage to WasWithinSameDocument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

Issue 2741313002: Renamed WasWithinSamePage to WasWithinSameDocument. (Closed)

Patch Set: Addressed review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/renderer/safe_browsing/phishing_classifier_delegate.cc ('k') | content/browser/frame_host/navigation_controller_impl_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

diff --git a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

index 19d02222603ba19c529e8500f2a4257edbf9b939..2c1e34efaeb036f07e0c032b7322392cd6d26886 100644

--- a/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

+++ b/components/subresource_filter/content/browser/content_subresource_filter_driver_factory_unittest.cc

@@ -362,7 +362,7 @@ class ContentSubresourceFilterDriverFactoryTest

std::unique_ptr<content::NavigationSimulator> navigation_simulator =

content::NavigationSimulator::CreateRendererInitiated(GURL(kExampleUrl),

main_rfh());

- navigation_simulator->CommitSamePage();

+ navigation_simulator->CommitSameDocument();

ExpectActivationSignalForFrame(main_rfh(), false);

::testing::Mock::VerifyAndClearExpectations(client());

}