Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Unified Diff: content/public/test/navigation_simulator.cc

Issue 2741313002: Renamed WasWithinSamePage to WasWithinSameDocument. (Closed)
Patch Set: Addressed review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/test/navigation_simulator.h ('k') | content/renderer/navigation_state_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/navigation_simulator.cc
diff --git a/content/public/test/navigation_simulator.cc b/content/public/test/navigation_simulator.cc
index ffd2485f1f77af393490e4717780544621a65769..7925507e2a53068a260a3c8cb4a86d0930aedf4d 100644
--- a/content/public/test/navigation_simulator.cc
+++ b/content/public/test/navigation_simulator.cc
@@ -299,7 +299,7 @@ void NavigationSimulator::Commit() {
params.socket_address.set_port(80);
params.history_list_was_cleared = false;
params.original_request_url = navigation_url_;
- params.was_within_same_page = false;
+ params.was_within_same_document = false;
params.page_state =
PageState::CreateForTesting(navigation_url_, false, nullptr, nullptr);
@@ -390,7 +390,7 @@ void NavigationSimulator::CommitErrorPage() {
params.did_create_new_entry = true;
params.url = navigation_url_;
params.transition = transition_;
- params.was_within_same_page = false;
+ params.was_within_same_document = false;
params.url_is_unreachable = true;
params.page_state =
PageState::CreateForTesting(navigation_url_, false, nullptr, nullptr);
@@ -408,7 +408,7 @@ void NavigationSimulator::CommitErrorPage() {
CHECK_EQ(1, num_did_finish_navigation_called_);
}
-void NavigationSimulator::CommitSamePage() {
+void NavigationSimulator::CommitSameDocument() {
CHECK_EQ(INITIALIZATION, state_)
<< "NavigationSimulator::CommitErrorPage should be the only "
"navigation event function called on the NavigationSimulator";
@@ -431,7 +431,7 @@ void NavigationSimulator::CommitSamePage() {
params.socket_address.set_port(80);
params.history_list_was_cleared = false;
params.original_request_url = navigation_url_;
- params.was_within_same_page = true;
+ params.was_within_same_document = true;
params.page_state =
PageState::CreateForTesting(navigation_url_, false, nullptr, nullptr);
« no previous file with comments | « content/public/test/navigation_simulator.h ('k') | content/renderer/navigation_state_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698