content/browser/frame_host/navigation_handle_impl.cc - Issue 2741313002: Renamed WasWithinSamePage to WasWithinSameDocument.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_handle_impl.cc

Issue 2741313002: Renamed WasWithinSamePage to WasWithinSameDocument. (Closed)

Patch Set: Addressed review comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_handle_impl.cc

diff --git a/content/browser/frame_host/navigation_handle_impl.cc b/content/browser/frame_host/navigation_handle_impl.cc

index c20e6bd5656d752813bcb5d31c12cdcbdc862b7e..0d114c1a05883e94caed7154c39bed6cfe8c2170 100644

--- a/content/browser/frame_host/navigation_handle_impl.cc

+++ b/content/browser/frame_host/navigation_handle_impl.cc

@@ -429,7 +429,7 @@ void NavigationHandleImpl::CallDidCommitNavigationForTesting(const GURL& url) {

params.searchable_form_encoding = std::string();

params.did_create_new_entry = false;

params.gesture = NavigationGestureUser;

- params.was_within_same_page = false;

+ params.was_within_same_document = false;

params.method = "GET";

params.page_state = PageState::CreateFromURL(url);

params.contents_mime_type = std::string("text/html");