Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2241)

Unified Diff: content/public/test/navigation_simulator.h

Issue 2741313002: Renamed WasWithinSamePage to WasWithinSameDocument. (Closed)
Patch Set: Addressed review comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/renderer/navigation_state.h ('k') | content/public/test/navigation_simulator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/test/navigation_simulator.h
diff --git a/content/public/test/navigation_simulator.h b/content/public/test/navigation_simulator.h
index 13a90a0490cedd05bc526ed87551e511e7919310..783546c1d25377afb2290aacf5ab13d95dce6b46 100644
--- a/content/public/test/navigation_simulator.h
+++ b/content/public/test/navigation_simulator.h
@@ -87,7 +87,7 @@ class NavigationSimulator : public WebContentsObserver {
// unique_ptr<NavigationSimulator> simulator =
// NavigationSimulator::CreateRendererInitiated(
// original_url, render_frame_host);
- // simulator->CommitSamePage();
+ // simulator->CommitSameDocument();
//
// Example of usage for a renderer-initiated navigation which is cancelled by
// a throttle upon redirecting. Note that registering the throttle is done
@@ -116,9 +116,9 @@ class NavigationSimulator : public WebContentsObserver {
// Simulates the commit of an error page following a navigation failure.
virtual void CommitErrorPage();
- // Simulates the commit of a same-page navigation, ie fragment navigations or
- // pushState/popState navigations.
- virtual void CommitSamePage();
+ // Simulates the commit of a same-document navigation, ie fragment navigations
+ // or pushState/popState navigations.
+ virtual void CommitSameDocument();
// --------------------------------------------------------------------------
« no previous file with comments | « content/public/renderer/navigation_state.h ('k') | content/public/test/navigation_simulator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698