Butler stream servers can generate client address.

Butler stream servers can generate client address.

Allow a StreamServer instance to generate client addresses. These
addresses can be processed by the stream client package to generate a
client for the corresponding StreamServer.

This also adds tests for UNIX and Windows stream server implementations.
These tests have the bonus of actually tying together this Address()
string to the "streamclient" package, confirming that they are
functional together.

In order for this connection to be made, the circular dependency that
"streamclient" had on "/logdog/client/butler" had to be broken. This is
done by moving the "local" client implementation into the "butler"
package space. This makes sense, since this implementation is an
internalization of the stream server.

BUG=chromium:698768
TEST=None

Review-Url: https://codereview.chromium.org/2737603003
Committed: https://github.com/luci/luci-go/commit/66a9c7cb1e03d984da7d0f5e12eebe2065b95602

[dnj, 2017-03-06 22:20:33]

Description was changed from

==========
Butler stream servers can generate client address.

Allow a StreamServer instance to generate client addresses. These
addresses can be processed by the stream client package to generate a
client for the corresponding StreamServer.

BUG=chromium:698768
TEST=None
==========

to

==========
Butler stream servers can generate client address.

Allow a StreamServer instance to generate client addresses. These
addresses can be processed by the stream client package to generate a
client for the corresponding StreamServer.

This also adds tests for UNIX and Windows stream server implementations.
These tests have the bonus of actually tying together this Address()
string to the "streamclient" package, confirming that they are
functional together.

In order for this connection to be made, the circular dependency that
"streamclient" had on "/logdog/client/butler" had to be broken. This is
done by moving the "local" client implementation into the "butler"
package space. This makes sense, since this implementation is an
internalization of the stream server.

BUG=chromium:698768
TEST=None
==========

[dnj, 2017-03-06 22:21:01]

dnj@chromium.org changed reviewers:
+ iannucci@chromium.org, nodir@chromium.org

[dnj, 2017-03-06 22:21:02]

PTAL

[nodir, 2017-03-06 22:29:44]

lgtm

https://codereview.chromium.org/2737603003/diff/20001/logdog/client/butler/st...
File logdog/client/butler/streamserver/namedPipe_windows.go (right):

https://codereview.chromium.org/2737603003/diff/20001/logdog/client/butler/st...
logdog/client/butler/streamserver/namedPipe_windows.go:36: name =
localNamedPipePrefix + name
this may be more than maxWindowsNamedPipeLength?

[dnj, 2017-03-06 22:39:31]

https://codereview.chromium.org/2737603003/diff/20001/logdog/client/butler/st...
File logdog/client/butler/streamserver/namedPipe_windows.go (right):

https://codereview.chromium.org/2737603003/diff/20001/logdog/client/butler/st...
logdog/client/butler/streamserver/namedPipe_windows.go:36: name =
localNamedPipePrefix + name
On 2017/03/06 22:29:44, nodir wrote:
> this may be more than maxWindowsNamedPipeLength?

This is fine - the name length is about the pipe name, not the full pipe path.

[dnj, 2017-03-06 22:39:34]

The CQ bit was checked by dnj@chromium.org

[commit-bot: I haz the power, 2017-03-06 22:39:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 23:10:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 23:10:48]

Try jobs failed on following builders:
  Luci-go Win Tester on luci.infra.try (JOB_FAILED,
https://luci-milo.appspot.com/swarming/task/34be98ea5bd88810)

[dnj, 2017-03-07 01:13:17]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-03-07 01:13:17]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2737603003/#ps60001
(title: "fix windows")

[commit-bot: I haz the power, 2017-03-07 01:13:20]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dnj, 2017-03-07 01:21:15]

The CQ bit was unchecked by dnj@chromium.org

[dnj, 2017-03-07 01:24:55]

The CQ bit was checked by dnj@chromium.org

[dnj, 2017-03-07 01:24:56]

The patchset sent to the CQ was uploaded after l-g-t-m from nodir@chromium.org
Link to the patchset: https://codereview.chromium.org/2737603003/#ps80001
(title: "better comment")

[commit-bot: I haz the power, 2017-03-07 01:25:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 01:31:54]

CQ is committing da patch.

Bot data: {"patchset_id": 80001, "attempt_start_ts": 1488849895714660,
"parent_rev": "670c47cc91c61bf5020c9a60cee69814bad56626", "commit_rev":
"66a9c7cb1e03d984da7d0f5e12eebe2065b95602"}

[commit-bot: I haz the power, 2017-03-07 01:31:57]

Description was changed from

==========
Butler stream servers can generate client address.

Allow a StreamServer instance to generate client addresses. These
addresses can be processed by the stream client package to generate a
client for the corresponding StreamServer.

This also adds tests for UNIX and Windows stream server implementations.
These tests have the bonus of actually tying together this Address()
string to the "streamclient" package, confirming that they are
functional together.

In order for this connection to be made, the circular dependency that
"streamclient" had on "/logdog/client/butler" had to be broken. This is
done by moving the "local" client implementation into the "butler"
package space. This makes sense, since this implementation is an
internalization of the stream server.

BUG=chromium:698768
TEST=None
==========

to

==========
Butler stream servers can generate client address.

Allow a StreamServer instance to generate client addresses. These
addresses can be processed by the stream client package to generate a
client for the corresponding StreamServer.

This also adds tests for UNIX and Windows stream server implementations.
These tests have the bonus of actually tying together this Address()
string to the "streamclient" package, confirming that they are
functional together.

In order for this connection to be made, the circular dependency that
"streamclient" had on "/logdog/client/butler" had to be broken. This is
done by moving the "local" client implementation into the "butler"
package space. This makes sense, since this implementation is an
internalization of the stream server.

BUG=chromium:698768
TEST=None

Review-Url: https://codereview.chromium.org/2737603003
Committed:
https://github.com/luci/luci-go/commit/66a9c7cb1e03d984da7d0f5e12eebe2065b95602
==========

[commit-bot: I haz the power, 2017-03-07 01:31:59]

Committed patchset #5 (id:80001) as
https://github.com/luci/luci-go/commit/66a9c7cb1e03d984da7d0f5e12eebe2065b95602