Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Unified Diff: logdog/client/cmd/logdog_butler/main_windows.go

Issue 2737603003: Butler stream servers can generate client address. (Closed)
Patch Set: better comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « logdog/client/cmd/logdog_butler/main_posix.go ('k') | logdog/client/cmd/logdog_butler/subcommand_run.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: logdog/client/cmd/logdog_butler/main_windows.go
diff --git a/logdog/client/cmd/logdog_butler/main_windows.go b/logdog/client/cmd/logdog_butler/main_windows.go
index a9de4f18b01c376d984973e6caa66e2cc7b81425..9d38a244aaace0e6f1dfe38fe08a50b61f65ce4b 100644
--- a/logdog/client/cmd/logdog_butler/main_windows.go
+++ b/logdog/client/cmd/logdog_butler/main_windows.go
@@ -6,7 +6,6 @@ package main
import (
"errors"
- "fmt"
"os"
"github.com/luci/luci-go/logdog/client/butler/streamserver"
@@ -47,10 +46,10 @@ func (u streamServerURI) Validate() error {
}
// Create a Windows stream server.
-func createStreamServer(ctx context.Context, uri streamServerURI) streamserver.StreamServer {
+func createStreamServer(ctx context.Context, uri streamServerURI) (streamserver.StreamServer, error) {
name, err := uri.Parse()
if err != nil {
panic("Failed to parse stream server URI.")
}
- return streamserver.NewNamedPipeServer(ctx, fmt.Sprintf(`\\.\pipe\%s`, name))
+ return streamserver.NewNamedPipeServer(ctx, name)
}
« no previous file with comments | « logdog/client/cmd/logdog_butler/main_posix.go ('k') | logdog/client/cmd/logdog_butler/subcommand_run.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698