logdog/client/butlerlib/streamclient/client_test.go - Issue 2737603003: Butler stream servers can generate client address.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: logdog/client/butlerlib/streamclient/client_test.go

Issue 2737603003: Butler stream servers can generate client address. (Closed)

Patch Set: better comment Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: logdog/client/butlerlib/streamclient/client_test.go

diff --git a/logdog/client/butlerlib/streamclient/client_test.go b/logdog/client/butlerlib/streamclient/client_test.go

index 05bd9dec392d9a99316075b58b97b5971f22171c..6a4eb852b99835e8fc6d751c0920b9b2612370b7 100644

--- a/logdog/client/butlerlib/streamclient/client_test.go

+++ b/logdog/client/butlerlib/streamclient/client_test.go

@@ -79,9 +79,9 @@ func TestClient(t *testing.T) {

Convey(`That can instantiate new Streams.`, func() {

stream, err := client.NewStream(flags)

So(err, ShouldBeNil)

- So(stream, ShouldHaveSameTypeAs, &streamImpl{})

+ So(stream, ShouldHaveSameTypeAs, &BaseStream{})

- si := stream.(*streamImpl)

+ si := stream.(*BaseStream)

So(si.WriteCloser, ShouldHaveSameTypeAs, &testStreamWriteCloser{})

tswc := si.WriteCloser.(*testStreamWriteCloser)