Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1116)

Unified Diff: logdog/client/butlerlib/streamclient/stream_test.go

Issue 2737603003: Butler stream servers can generate client address. (Closed)
Patch Set: better comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « logdog/client/butlerlib/streamclient/stream.go ('k') | logdog/client/cmd/logdog_butler/main_posix.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: logdog/client/butlerlib/streamclient/stream_test.go
diff --git a/logdog/client/butlerlib/streamclient/stream_test.go b/logdog/client/butlerlib/streamclient/stream_test.go
index b210b463326bb334410a446cd437d4b2987cf900..87e2cc86bce83a24c222ab572c1476f4e12a6bc5 100644
--- a/logdog/client/butlerlib/streamclient/stream_test.go
+++ b/logdog/client/butlerlib/streamclient/stream_test.go
@@ -18,13 +18,13 @@ import (
func TestStreamImpl(t *testing.T) {
Convey(`A stream writing to a buffer`, t, func() {
buf := bytes.Buffer{}
- si := streamImpl{
+ si := BaseStream{
WriteCloser: &nopWriteCloser{Writer: &buf},
- props: (&streamproto.Flags{}).Properties(),
+ P: (&streamproto.Flags{}).Properties(),
}
Convey(`TEXT`, func() {
- si.props.StreamType = logpb.StreamType_TEXT
+ si.P.StreamType = logpb.StreamType_TEXT
Convey(`Will error if WriteDatagram is called.`, func() {
So(si.WriteDatagram([]byte(nil)), ShouldNotBeNil)
@@ -39,7 +39,7 @@ func TestStreamImpl(t *testing.T) {
})
Convey(`DATAGRAM`, func() {
- si.props.StreamType = logpb.StreamType_DATAGRAM
+ si.P.StreamType = logpb.StreamType_DATAGRAM
Convey(`Will error if Write is called.`, func() {
_, err := si.Write([]byte(nil))
« no previous file with comments | « logdog/client/butlerlib/streamclient/stream.go ('k') | logdog/client/cmd/logdog_butler/main_posix.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698