Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Unified Diff: logdog/client/cmd/logdog_butler/subcommand_serve.go

Issue 2737603003: Butler stream servers can generate client address. (Closed)
Patch Set: better comment Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « logdog/client/cmd/logdog_butler/subcommand_run.go ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: logdog/client/cmd/logdog_butler/subcommand_serve.go
diff --git a/logdog/client/cmd/logdog_butler/subcommand_serve.go b/logdog/client/cmd/logdog_butler/subcommand_serve.go
index c2c586072aeaf30cad8e408fa370e23ec56244ac..b6fdf519047cba599fbbd6697e66e5f962a1827e 100644
--- a/logdog/client/cmd/logdog_butler/subcommand_serve.go
+++ b/logdog/client/cmd/logdog_butler/subcommand_serve.go
@@ -40,7 +40,11 @@ func (cmd *serveCommandRun) Run(app subcommands.Application, args []string, _ su
}.Errorf(a, "Invalid stream server URI.")
return configErrorReturnCode
}
- streamServer := createStreamServer(a, cmd.uri)
+ streamServer, err := createStreamServer(a, cmd.uri)
+ if err != nil {
+ log.WithError(err).Errorf(a, "Failed to create stream server.")
+ return runtimeErrorReturnCode
+ }
if err := streamServer.Listen(); err != nil {
log.Errorf(log.SetError(a, err), "Failed to connect to stream server.")
« no previous file with comments | « logdog/client/cmd/logdog_butler/subcommand_run.go ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698