Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(7)

Issue 2737413004: Add a Certificate Viewer link to the Page Info dropdown (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 months, 1 week ago by elawrence
Modified:
3 months, 3 weeks ago
Reviewers:
CC:
chromium-reviews, markusheintz_, msramek+watch_chromium.org, oshima+watch_chromium.org, raymes+watch_chromium.org, srahim+watch_chromium.org, tfarina
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a Certificate Viewer link to the Page Info dropdown In Chrome 55, we removed the easy path from Page Info to the Certificate Viewer dialog. This change puts it back in a new Certificate view just above the Cookie view. BUG=663971

Patch Set 1 : Add Cocoa, Fix MaxViews, Add Flag #

Total comments: 15

Patch Set 2 : Add subviews #

Total comments: 8

Patch Set 3 : Rebase, update tooltip #

Unified diffs Side-by-side diffs Delta from patch set Stats (+405 lines, -186 lines) Patch
A chrome/app/theme/default_100_percent/common/certificate.png View Binary file 0 comments Download
A chrome/app/theme/default_200_percent/common/certificate.png View Binary file 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 2 3 chunks +9 lines, -3 lines 0 comments Download
M chrome/browser/flag_descriptions.h View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/flag_descriptions.cc View 1 2 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h View 1 2 4 chunks +15 lines, -3 lines 0 comments Download
M chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.mm View 1 2 8 chunks +171 lines, -113 lines 0 comments Download
M chrome/browser/ui/page_info/page_info_ui.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/ui/page_info/page_info_ui.cc View 1 2 3 chunks +16 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/page_info/page_info_bubble_view.h View 1 2 4 chunks +10 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/page_info/page_info_bubble_view.cc View 1 2 10 chunks +136 lines, -60 lines 0 comments Download
M chrome/common/chrome_switches.h View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/chrome_switches.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M components/page_info_strings.grdp View 1 2 1 chunk +15 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +1 line, -0 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 25 (17 generated)
elawrence
PTAL at the PageInfo code?
4 months, 2 weeks ago (2017-03-31 20:52:48 UTC) #10
lgarron
Sorry I didn't get to this yet. I left some comments, but looks on the ...
4 months, 2 weeks ago (2017-04-05 02:06:26 UTC) #13
elawrence
Thanks for having a look. > My main concerns is that this CL currently copies ...
4 months, 2 weeks ago (2017-04-05 15:26:19 UTC) #14
elawrence
https://codereview.chromium.org/2737413004/diff/60001/chrome/app/generated_resources.grd File chrome/app/generated_resources.grd (right): https://codereview.chromium.org/2737413004/diff/60001/chrome/app/generated_resources.grd#newcode7131 chrome/app/generated_resources.grd:7131: <message name="IDS_PAGE_INFO_CERTIFICATE" desc="Title of the certificate area in the ...
4 months, 2 weeks ago (2017-04-06 01:06:11 UTC) #16
lgarron
On 2017/04/05 at 15:26:19, elawrence wrote: > Thanks for having a look. > > > ...
4 months, 1 week ago (2017-04-06 19:33:59 UTC) #17
elawrence
Please take another look? I've added Subviews for the Cookie/Certificate subsections. The Views code now ...
4 months ago (2017-04-19 21:08:50 UTC) #19
lgarron
I think the Cocoa approach in this CL is pretty good given the existing code! ...
3 months, 4 weeks ago (2017-04-20 19:12:56 UTC) #20
elawrence
3 months, 3 weeks ago (2017-04-27 14:56:34 UTC) #21
https://codereview.chromium.org/2737413004/diff/140001/chrome/browser/flag_de...
File chrome/browser/flag_descriptions.cc (right):

https://codereview.chromium.org/2737413004/diff/140001/chrome/browser/flag_de...
chrome/browser/flag_descriptions.cc:201: //  Flag and values for MHTML Generator
options lab.
On 2017/04/20 19:12:56, lgarron wrote:
> Nit: I like to put conceptually unrelated fixes in a separate CL.

Okay, I've re-misspelled this.

https://codereview.chromium.org/2737413004/diff/140001/chrome/browser/ui/coco...
File chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h (right):

https://codereview.chromium.org/2737413004/diff/140001/chrome/browser/ui/coco...
chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h:42: // are
displayed when the user clicks the Page Info icon.
On 2017/04/20 19:12:56, lgarron wrote:
> Nit: I usually call this the "omnibox security indicator" (although admittedly
> that's a bit vague).

Done.

https://codereview.chromium.org/2737413004/diff/140001/chrome/browser/ui/view...
File chrome/browser/ui/views/page_info/page_info_popup_view.cc (right):

https://codereview.chromium.org/2737413004/diff/140001/chrome/browser/ui/view...
chrome/browser/ui/views/page_info/page_info_popup_view.cc:734:
certificate_view_->SetLinkTooltip(issuer);
On 2017/04/20 19:12:56, lgarron wrote:
> Is it common to add information like this in a tooltip?
> I would probably run it by UI if you haven't yet.

Done.

https://codereview.chromium.org/2737413004/diff/140001/components/pageinfo_st...
File components/pageinfo_strings.grdp (right):

https://codereview.chromium.org/2737413004/diff/140001/components/pageinfo_st...
components/pageinfo_strings.grdp:4: <!-- Certificate Viewer link -->
On 2017/04/20 19:12:56, lgarron wrote:
> FYI: This file was renamed; you'll have to rebase at least once before
landing.

Acknowledged.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld b40b6558b