Add a Certificate Viewer link to the Page Info dropdown

chrome/browser/about_flags.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/about_flags.h"
 
 #include <iterator>
 #include <map>
 #include <set>
 #include <utility>
@@ skipping 2339 matching lines @@
     {"lsd-permission-prompt", flag_descriptions::kLsdPermissionPromptName,
      flag_descriptions::kLsdPermissionPromptDescription, kOsAndroid,
      FEATURE_VALUE_TYPE(features::kLsdPermissionPrompt)},
 #endif
 
 #if defined(OS_CHROMEOS)
     {"enable-touchscreen-calibration",
      flag_descriptions::kTouchscreenCalibrationName,
      flag_descriptions::kTouchscreenCalibrationDescription, kOsCrOS,
      SINGLE_VALUE_TYPE(chromeos::switches::kEnableTouchCalibrationSetting)},
-#endif // defined(OS_CHROMEOS)
+#endif  // defined(OS_CHROMEOS)

[lgarron, 2017/04/05 02:06:25]

Nit: don't change indentation of unrelated code (maybe this is due to some rogue
`git cl format`ing?)

[elawrence, 2017/04/06 01:06:10]

This is from git cl lint. I wasn't able to quickly find the documented best
practice here? Is it to just do a different CL that fixes linting problems?

 
 #if defined(OS_WIN)
     {"gdi-text-printing", flag_descriptions::kGdiTextPrinting,
      flag_descriptions::kGdiTextPrintingDescription, kOsWin,
      FEATURE_VALUE_TYPE(features::kGdiTextPrinting)},
     {"postscript-printing", flag_descriptions::kPostscriptPrinting,
      flag_descriptions::kPostscriptPrintingDescription, kOsWin,
      FEATURE_VALUE_TYPE(features::kPostScriptPrinting)},
 #endif  // defined(OS_WIN)
 
 #if defined(OS_CHROMEOS)
     {"show-arc-files-app", flag_descriptions::kShowArcFilesAppName,
      flag_descriptions::kShowArcFilesAppDescription, kOsCrOS,
      FEATURE_VALUE_TYPE(arc::kShowArcFilesAppFeature)},
-#endif // defined(OS_CHROMEOS)
+#endif  // defined(OS_CHROMEOS)
 
 #if defined(OS_ANDROID)
     {"aia-fetching", flag_descriptions::kAiaFetchingName,
      flag_descriptions::kAiaFetchingDescription, kOsAndroid,
      FEATURE_VALUE_TYPE(net::CertVerifyProcAndroid::kAIAFetchingFeature)},
 #endif
 
 #if defined(OS_CHROMEOS)
     {"force-enable-stylus-tools",
      flag_descriptions::kForceEnableStylusToolsName,
      flag_descriptions::kForceEnableStylusToolsDescription, kOsCrOS,
      SINGLE_VALUE_TYPE(ash::switches::kAshForceEnablePalette)},
-#endif // defined(OS_CHROMEOS)
+#endif  // defined(OS_CHROMEOS)
 
     {"enable-midi-manager-dynamic-instantiation",
      flag_descriptions::kEnableMidiManagerDynamicInstantiationName,
      flag_descriptions::kEnableMidiManagerDynamicInstantiationDescription,
      kOsAll,
      FEATURE_VALUE_TYPE(midi::features::kMidiManagerDynamicInstantiation)},
 
 #if defined(OS_WIN)
     {"new-usb-backend", flag_descriptions::kNewUsbBackendName,
      flag_descriptions::kNewUsbBackendDescription, kOsWin,
@@ skipping 83 matching lines @@
                                     kDelayNavigationFeatureVariations,
                                     "DelayNavigation")},
 
 #if defined(OS_ANDROID)
     {"enable-custom-context-menu",
      flag_descriptions::kEnableCustomContextMenuName,
      flag_descriptions::kEnableCustomContextMenuDescription, kOsAndroid,
      FEATURE_VALUE_TYPE(chrome::android::kCustomContextMenu)},
 #endif  // OS_ANDROID
 
+#if defined(TOOLKIT_VIEWS) || (defined(OS_MACOSX) && !defined(OS_IOS))
+    {"show-cert-button", flag_descriptions::kShowCertButtonOnPageInfoName,

[lgarron, 2017/04/05 02:06:25]

Nit: If it's going to be a link in the foreseeable future, could we call this
kShowCertLinkOnPageInfoName?

[elawrence, 2017/04/06 01:06:10]

I suppose it's a link today and likely to remain that way. I didn't think too
hard about the flag naming because the flag itself is slated to go away in M60.

+     flag_descriptions::kShowCertButtonOnPageInfoDescription, kOsDesktop,
+     SINGLE_VALUE_TYPE(switches::kShowCertButton)},
+#endif
+
     // NOTE: Adding new command-line switches requires adding corresponding
     // entries to enum "LoginCustomFlags" in histograms.xml. See note in
     // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
 };
 
 class FlagsStateSingleton {
  public:
   FlagsStateSingleton()
       : flags_state_(kFeatureEntries, arraysize(kFeatureEntries)) {}
   ~FlagsStateSingleton() {}
@@ skipping 188 matching lines @@
 const base::HistogramBase::Sample kBadSwitchFormatHistogramId = 0;
 
 const FeatureEntry* GetFeatureEntries(size_t* count) {
   *count = arraysize(kFeatureEntries);
   return kFeatureEntries;
 }
 
 }  // namespace testing
 
 }  // namespace about_flags