Add a Certificate Viewer link to the Page Info dropdown

chrome/browser/ui/cocoa/page_info/page_info_bubble_controller.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_COCOA_PAGE_INFO_PAGE_INFO_BUBBLE_CONTROLLER_H_
 #define CHROME_BROWSER_UI_COCOA_PAGE_INFO_PAGE_INFO_BUBBLE_CONTROLLER_H_
 
 #import <Cocoa/Cocoa.h>
 
 #include <memory>
 
 #include "base/mac/scoped_nsobject.h"
 #include "base/macros.h"
 #import "chrome/browser/ui/cocoa/omnibox_decoration_bubble_controller.h"
 #include "chrome/browser/ui/page_info/page_info_ui.h"
 #include "content/public/browser/web_contents_observer.h"
+#import "ui/base/cocoa/flipped_view.h"
 
 class PageInfoUIBridge;
 
 namespace content {
 class WebContents;
 }
 
 namespace net {
 class X509Certificate;
 }
 
 namespace security_state {
 struct SecurityInfo;
 }  // namespace security_state
 
+@interface InspectLinkView : FlippedView {
+ @private
+  NSButton* actionLink_;
+}
+
+- (id)initWithFrame:(NSRect)frame;
+@end
+
 // This NSWindowController subclass manages the InfoBubbleWindow and view that
-// are displayed when the user clicks the favicon or security lock icon.
+// are displayed when the user clicks the Page Info icon.

[lgarron, 2017/04/20 19:12:56]

Nit: I usually call this the "omnibox security indicator" (although admittedly
that's a bit vague).

[elawrence, 2017/04/27 14:56:34]

Done.

 @interface PageInfoBubbleController : OmniboxDecorationBubbleController {
  @private
   content::WebContents* webContents_;
 
   base::scoped_nsobject<NSView> contentView_;
 
   // The main content view for the Permissions tab.
   NSView* securitySectionView_;
 
   // Displays the short security summary for the page
@@ skipping 11 matching lines @@
   // URL of the page for which the bubble is shown.
   GURL url_;
 
   // Displays a paragraph to accompany the reset decisions button, explaining
   // that the user has made a decision to trust an invalid security certificate
   // for the current site.
   // This field only shows when there is an acrive certificate exception.
   NSTextField* resetDecisionsField_;
 
   // The link button for revoking certificate decisions.
-  // This link only shows when there is an acrive certificate exception.
+  // This link only shows when there is an active certificate exception.
   NSButton* resetDecisionsButton_;
 
   // The server certificate from the identity info. This should always be
   // non-null on a cryptographic connection, and null otherwise.
   scoped_refptr<net::X509Certificate> certificate_;
 
   // Separator line.
   NSView* separatorAfterSecuritySection_;
 
   // Container for the site settings section.
   NSView* siteSettingsSectionView_;
 
+  // Container for certificate info in the site settings section.
+  InspectLinkView* certificateView_;
+
   // Container for cookies info in the site settings section.
-  NSView* cookiesView_;
+  InspectLinkView* cookiesView_;
 
   // Container for permission info in the site settings section.
   NSView* permissionsView_;
 
   // Whether the permissionView_ shows anything.
   BOOL permissionsPresent_;
 
   // The link button for showing site settings.
   NSButton* siteSettingsButton_;
 
@@ skipping 55 matching lines @@
   // The WebContents the bubble UI is attached to.
   content::WebContents* web_contents_;
 
   // The Cocoa controller for the bubble UI.
   PageInfoBubbleController* bubble_controller_;
 
   DISALLOW_COPY_AND_ASSIGN(PageInfoUIBridge);
 };
 
 #endif  // CHROME_BROWSER_UI_COCOA_PAGE_INFO_PAGE_INFO_BUBBLE_CONTROLLER_H_