Add a Certificate Viewer link to the Page Info dropdown

chrome/browser/flag_descriptions.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/flag_descriptions.h"
 
 namespace flag_descriptions {
 
 //  Material Design version of chrome://bookmarks
 
@@ skipping 180 matching lines @@
 const char kMarkHttpAsDescription[] = "Change the UI treatment for HTTP pages";
 
 const char kMarkHttpAsDangerous[] = "Always mark HTTP as actively dangerous";
 
 const char kSavePageAsMhtmlName[] = "Save Page as MHTML";
 
 const char kSavePageAsMhtmlDescription[] =
     "Enables saving pages as MHTML: a single text file containing HTML and "
     "all sub-resources.";
 
-//  Flag and values for MHTML Geenrator options lab.
+//  Flag and values for MHTML Generator options lab.
 
 const char kMhtmlGeneratorOptionName[] = "MHTML Generation Option";
 
 const char kMhtmlGeneratorOptionDescription[] =
     "Provides experimental options for MHTML file generator.";
 
 const char kMhtmlSkipNostoreMain[] = "Skips no-store main frame.";
 
 const char kMhtmlSkipNostoreAll[] = "Skips all no-store resources.";
 
@@ skipping 1304 matching lines @@
 #if defined(OS_WIN)
 
 const char kEnableAppcontainerName[] = "Enable AppContainer Lockdown.";
 
 const char kEnableAppcontainerDescription[] =
     "Enables the use of an AppContainer on sandboxed processes to improve "
     "security.";
 
 #endif  // defined(OS_WIN)
 
+#if defined(TOOLKIT_VIEWS) || (defined(OS_MACOSX) && !defined(OS_IOS))
+
+const char kShowCertButtonOnPageInfoName[] = "Show certificate button";

[lgarron, 2017/04/05 02:06:25]

ditto

[elawrence, 2017/04/06 01:06:11]

Done.

+
+const char kShowCertButtonOnPageInfoDescription[] =
+    "Shows a button that launches the certificate viewer from the Page "

[lgarron, 2017/04/05 02:06:25]

I would write: Add a link from the Page Info bubble to the certificate viewer
for HTTPS sites.

[elawrence, 2017/04/06 01:06:11]

Done.

+    "Information dropdown window on HTTPS sites.";

[lgarron, 2017/04/05 02:06:25]

I don't think we call it "dropdown window" anywhere? I would prefer to avoid
introducing any new names for Page Info if possible, so I'd prefer "Page
Info[rmation] bubble".

[elawrence, 2017/04/06 01:06:10]

Done.

+
+#endif  // defined(TOOLKIT_VIEWS) || (defined(OS_MACOSX) && !defined(OS_IOS))
+
 #if defined(TOOLKIT_VIEWS) || defined(OS_ANDROID)
 
 const char kAutofillCreditCardUploadName[] =
     "Enable offering upload of Autofilled credit cards";
 
 const char kAutofillCreditCardUploadDescription[] =
     "Enables a new option to upload credit cards to Google Payments for "
     "sync to all Chrome devices.";
 
 #endif  // defined(TOOLKIT_VIEWS) || defined(OS_ANDROID)
@@ skipping 1364 matching lines @@
 const char kEnableEhvInputName[] =
     "Emoji, handwriting and voice input on opt-in IME menu";
 
 const char kEnableEhvInputDescription[] =
     "Enable access to emoji, handwriting and voice input form opt-in IME "
     "menu.";
 
 #endif  // #if defined(OS_CHROMEOS)
 
 }  // namespace flag_descriptions