Get rid of FrameSelection::setSelection() taking VisibleSelection

Get rid of FrameSelection::setSelection() taking VisibleSelection

This patch gets rid of |FrameSelection::setSelection()| taking
|VisibleSelection| to reduce usage of |VisibleSelection| for improving code
health.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2736613003
Cr-Commit-Position: refs/heads/master@{#455128}
Committed: https://chromium.googlesource.com/chromium/src/+/28984afb360fd50ff1c57e0e09ab7ef22b169073

[yosin_UTC9, 2017-03-06 08:41:53]

Description was changed from

==========
2017-03-06T17:40:33

2017-03-06T17:40:29

BUG=
==========

to

==========
Get rid of FrameSelection::setSelection() taking VisibleSelection

BUG=n/a
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-03-06 08:41:57]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-06 08:42:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-06 10:28:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-06 10:28:18]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-03-07 02:16:24]

yosin@chromium.org changed reviewers:
+ tkent@chromium.org, xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-03-07 02:16:25]

PTAL

Changes in core/editing and core/page

[tkent, 2017-03-07 03:39:12]

lgtm

[yosin_UTC9, 2017-03-07 03:52:46]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-07 03:53:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 04:04:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 04:04:33]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yosin_UTC9, 2017-03-07 04:51:24]

Description was changed from

==========
Get rid of FrameSelection::setSelection() taking VisibleSelection

BUG=n/a
TEST=n/a; no behavior changes
==========

to

==========
Get rid of FrameSelection::setSelection() taking VisibleSelection

This patch gets rid of |FrameSelection::setSelection()| taking
|VisibleSelection| to reduce usage of |VisibleSelection| for improving code
health.

BUG=657237
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-03-07 04:55:19]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-03-07 04:55:20]

The patchset sent to the CQ was uploaded after l-g-t-m from tkent@chromium.org
Link to the patchset: https://codereview.chromium.org/2736613003/#ps20001
(title: "2017-03-07T13:53:20 rebase")

[commit-bot: I haz the power, 2017-03-07 04:56:18]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 07:31:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 07:31:53]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yosin_UTC9, 2017-03-07 07:56:24]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-07 07:56:47]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 09:30:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-07 09:30:05]

Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[yosin_UTC9, 2017-03-07 14:37:21]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-03-07 14:38:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 17:58:14]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1488897441040790,
"parent_rev": "7647683e57f52c2dd80d14e9475df3763a226b64", "commit_rev":
"28984afb360fd50ff1c57e0e09ab7ef22b169073"}

[commit-bot: I haz the power, 2017-03-07 17:58:51]

Description was changed from

==========
Get rid of FrameSelection::setSelection() taking VisibleSelection

This patch gets rid of |FrameSelection::setSelection()| taking
|VisibleSelection| to reduce usage of |VisibleSelection| for improving code
health.

BUG=657237
TEST=n/a; no behavior changes
==========

to

==========
Get rid of FrameSelection::setSelection() taking VisibleSelection

This patch gets rid of |FrameSelection::setSelection()| taking
|VisibleSelection| to reduce usage of |VisibleSelection| for improving code
health.

BUG=657237
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2736613003
Cr-Commit-Position: refs/heads/master@{#455128}
Committed:
https://chromium.googlesource.com/chromium/src/+/28984afb360fd50ff1c57e0e09ab...
==========

[commit-bot: I haz the power, 2017-03-07 17:58:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/28984afb360fd50ff1c57e0e09ab...