third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp - Issue 2736613003: Get rid of FrameSelection::setSelection() taking VisibleSelection

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

Issue 2736613003: Get rid of FrameSelection::setSelection() taking VisibleSelection (Closed)

Patch Set: 2017-03-07T13:53:20 rebase Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

index 2f2478ea8995c980aba97a71120a36575bfe5239..478c8b7fccde663f9bbb365f8b1a32b4f2aac3e0 100644

--- a/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/EditorCommand.cpp

@@ -1730,7 +1730,7 @@ static bool executeSwapWithMark(LocalFrame& frame,

frame.selection().computeVisibleSelectionInDOMTreeDeprecated();

if (mark.isNone() || selection.isNone())

return false;

- frame.selection().setSelection(mark);

+ frame.selection().setSelection(mark.asSelection());

frame.editor().setMark(selection);

return true;

}