Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(414)

Unified Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2736613003: Get rid of FrameSelection::setSelection() taking VisibleSelection (Closed)
Patch Set: 2017-03-07T13:53:20 rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/FrameSelection.h
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.h b/third_party/WebKit/Source/core/editing/FrameSelection.h
index 5524f80bb9cc12f18814b36e728e4ff0305e1fce..da7db3235da43997f2c2efda3254b49a3afde231 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.h
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.h
@@ -123,14 +123,6 @@ class CORE_EXPORT FrameSelection final
SetSelectionOptions = CloseTyping | ClearTypingStyle,
CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded,
TextGranularity = CharacterGranularity);
-
- // TODO(yosin): We should use |SelectionInDOMTree| version instead of
- // |VisibleSelection| version.
- void setSelection(const VisibleSelection&,
- HandleVisibility = HandleVisibility::NotVisible,
- SetSelectionOptions = CloseTyping | ClearTypingStyle,
- CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded,
- TextGranularity = CharacterGranularity);
bool setSelectedRange(
const EphemeralRange&,
TextAffinity,
« no previous file with comments | « third_party/WebKit/Source/core/editing/Editor.cpp ('k') | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698