Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(771)

Side by Side Diff: third_party/WebKit/Source/core/editing/FrameSelection.h

Issue 2736613003: Get rid of FrameSelection::setSelection() taking VisibleSelection (Closed)
Patch Set: 2017-03-07T13:53:20 rebase Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights 2 * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010 Apple Inc. All rights
3 * reserved. 3 * reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 105 matching lines...) Expand 10 before | Expand all | Expand 10 after
116 116
117 void setSelection(const SelectionInDOMTree&, 117 void setSelection(const SelectionInDOMTree&,
118 SetSelectionOptions = CloseTyping | ClearTypingStyle, 118 SetSelectionOptions = CloseTyping | ClearTypingStyle,
119 CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded, 119 CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded,
120 TextGranularity = CharacterGranularity); 120 TextGranularity = CharacterGranularity);
121 121
122 void setSelection(const SelectionInFlatTree&, 122 void setSelection(const SelectionInFlatTree&,
123 SetSelectionOptions = CloseTyping | ClearTypingStyle, 123 SetSelectionOptions = CloseTyping | ClearTypingStyle,
124 CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded, 124 CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded,
125 TextGranularity = CharacterGranularity); 125 TextGranularity = CharacterGranularity);
126
127 // TODO(yosin): We should use |SelectionInDOMTree| version instead of
128 // |VisibleSelection| version.
129 void setSelection(const VisibleSelection&,
130 HandleVisibility = HandleVisibility::NotVisible,
131 SetSelectionOptions = CloseTyping | ClearTypingStyle,
132 CursorAlignOnScroll = CursorAlignOnScroll::IfNeeded,
133 TextGranularity = CharacterGranularity);
134 bool setSelectedRange( 126 bool setSelectedRange(
135 const EphemeralRange&, 127 const EphemeralRange&,
136 TextAffinity, 128 TextAffinity,
137 SelectionDirectionalMode = SelectionDirectionalMode::NonDirectional, 129 SelectionDirectionalMode = SelectionDirectionalMode::NonDirectional,
138 FrameSelection::SetSelectionOptions = CloseTyping | ClearTypingStyle); 130 FrameSelection::SetSelectionOptions = CloseTyping | ClearTypingStyle);
139 void selectAll(); 131 void selectAll();
140 void clear(); 132 void clear();
141 133
142 // TODO(tkent): These two functions were added to fix crbug.com/695211 without 134 // TODO(tkent): These two functions were added to fix crbug.com/695211 without
143 // changing focus behavior. Once we fix crbug.com/690272, we can remove these 135 // changing focus behavior. Once we fix crbug.com/690272, we can remove these
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
324 316
325 } // namespace blink 317 } // namespace blink
326 318
327 #ifndef NDEBUG 319 #ifndef NDEBUG
328 // Outside the WebCore namespace for ease of invocation from gdb. 320 // Outside the WebCore namespace for ease of invocation from gdb.
329 void showTree(const blink::FrameSelection&); 321 void showTree(const blink::FrameSelection&);
330 void showTree(const blink::FrameSelection*); 322 void showTree(const blink::FrameSelection*);
331 #endif 323 #endif
332 324
333 #endif // FrameSelection_h 325 #endif // FrameSelection_h
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/editing/Editor.cpp ('k') | third_party/WebKit/Source/core/editing/FrameSelection.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698